The text-transform property should support `full-width` and/or `full-size-kana` in combination with one of the case transforms
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(3 files)
Our parsing and implementation of text-transform
is incorrect. The spec[1] says:
Value: none | [capitalize | uppercase | lowercase ] || full-width || full-size-kana
which means it should be possible to use both the full-width
and full-size-kana
transforms together, not only individually, and either or both of them can be combined with one of the letter-case transforms.
So things like text-transform: uppercase full-width
should work. But currently, we accept only a single keyword, so this is a parse error.
(Fixing this will require some changes to the implementation of the transforms, as well as to the CSS parsing and computation, as the code currently assumes that only a single value will be in effect.)
[1] https://drafts.csswg.org/css-text/#text-transform-property
Comment 1•5 years ago
|
||
The style system changes for this are not hard. If somebody is interested in hacking on this I'm happy to mentor.
We probably want to make the text-transform specified and computed value a bitfield to represent all the combinations that we need, or maybe a struct with both the case transform an the other transforms.
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
I figured looking at this might be a good way for me to learn a bit, so I've taken a stab at it, and have a patch that seems to work so far. There are probably better ways to do things, so suggestions/corrections/advice will be very welcome - thanks!
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D27402
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D27403
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6791dc830ee3 Allow full-width and/or full-size-kana values of text-transform to be combined with a case transformation. r=emilio https://hg.mozilla.org/integration/autoland/rev/b7de63e1f333 Fix WPT parsing tests for text-transform to reflect proper serialization of multiple values. r=emilio https://hg.mozilla.org/integration/autoland/rev/5e8efe9fed4c Add a WPT reftest for rendering of text-transform with combinations of values. r=emilio
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6791dc830ee3
https://hg.mozilla.org/mozilla-central/rev/b7de63e1f333
https://hg.mozilla.org/mozilla-central/rev/5e8efe9fed4c
Updated•5 years ago
|
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16520 for changes under testing/web-platform/tests
Upstream PR merged
Description
•