Add Android javadoc lint so that javadoc errors cause backouts
Categories
(GeckoView :: General, defect, P3)
Tracking
(firefox66 wontfix, firefox67 wontfix, firefox68 wontfix, firefox69 wontfix, firefox70 fixed)
People
(Reporter: agi, Assigned: nalexander)
References
Details
Attachments
(1 file, 1 obsolete file)
There's a javadoc error checked in in the current mozilla-central that somehow got in and now it's failing try builds.
See here e.g.: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cdb6c9de509c7aef5b2b58a1e23bf5bf77bf12d
We should figure out how these things pass the tests when they are checked in.
|
||
Updated•5 years ago
|
|
Reporter | |
Comment 1•5 years ago
|
||
Maybe all we need is a lint that runs javadoc and errors out in case of warnings.
|
Assignee | |
Comment 2•5 years ago
|
||
The issue is that gv-docs is tier 2 (https://searchfox.org/mozilla-central/source/taskcluster/ci/build/android-stuff.yml#270) and doesn't work on try (since it builds docs and tries to publish, which fails without real tokens). We can do lots here; I do like making this a lint (and tier 1, tbh).
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
This applies the error listener just to the Javadoc tasks (previously,
it applied to the apiGenerate* tasks as well, 'cuz they inherit from
Javadoc).
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D41634
|
|
Assignee | |
Comment 5•5 years ago
|
||
A try, that I think will fail 'cuz of existing Javadoc errors, is percolating at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b87850beb00ac48853051538afec03e5a37454ed.
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b77bedf4ca3 Add `android-javadoc` lint. r=agi
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
Description
•