Use :root instead of #main-window in browser/themes/shared/identity-block/identity-block.inc.css

RESOLVED FIXED in Firefox 68

Status

()

task
P3
normal
RESOLVED FIXED
3 months ago
Last month

People

(Reporter: dao, Assigned: damien.feugas, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

3 months ago

+++ This bug was initially created as a clone of Bug #1541799 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/identity-block/identity-block.inc.css there's currently one selector that should use :root instead of #main-window.

Assignee

Comment 1

3 months ago

Hey! As a first contribution, I'd like to take this one.

Comment 3

3 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38cc85765558
use :root selector in identity-block stylesheet r=dao
Reporter

Updated

3 months ago
Assignee: nobody → damien.feugas
Reporter

Updated

3 months ago
See Also: → 1543043

Comment 4

3 months ago
bugherder
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Comment on attachment 9058054 [details]
Bug 1542187 - Changed #mainwindow to :root

Revision D27413 was moved to bug 1543043. Setting attachment 9058054 [details] to obsolete.

Attachment #9058054 - Attachment is obsolete: true
Reporter

Updated

2 months ago
See Also: → 1544680
Reporter

Updated

Last month
See Also: → 1554609
You need to log in before you can comment on or make changes to this bug.