1542187 - Use :root instead of #main-window in browser/themes/shared/identity-block/identity-block.inc.css

Status: RESOLVED FIXED

(Firefox :: Theme, task, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1541799 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/identity-block/identity-block.inc.css there's currently one selector that should use :root instead of #main-window.

Comment 1

[Damien]

Hey! As a first contribution, I'd like to take this one.

Comment 2

[Damien]

Attachment: Bug 1542187: use :root selector in identity-block stylesheet

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38cc85765558
use :root selector in identity-block stylesheet r=dao

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/38cc85765558

Comment 5

[Arpit Bharti]

Attachment: Bug 1542187 - Changed #mainwindow to :root

Comment 6

[Phabricator Automation]

Comment on attachment 9058054 [details]
Bug 1542187 - Changed #mainwindow to :root

Revision D27413 was moved to bug 1543043. Setting attachment 9058054 [details] to obsolete.