Closed Bug 1542187 Opened 1 year ago Closed 1 year ago

Use :root instead of #main-window in browser/themes/shared/identity-block/identity-block.inc.css

Categories

(Firefox :: Theme, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: dao, Assigned: damien.feugas, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1541799 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/identity-block/identity-block.inc.css there's currently one selector that should use :root instead of #main-window.

Hey! As a first contribution, I'd like to take this one.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38cc85765558
use :root selector in identity-block stylesheet r=dao
Assignee: nobody → damien.feugas
See Also: → 1543043
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Comment on attachment 9058054 [details]
Bug 1542187 - Changed #mainwindow to :root

Revision D27413 was moved to bug 1543043. Setting attachment 9058054 [details] to obsolete.

Attachment #9058054 - Attachment is obsolete: true
See Also: → 1544680
See Also: → 1554609
See Also: → 1561552
You need to log in before you can comment on or make changes to this bug.