1542210 - On opening a modal window containing xul checkboxes, the error JavaScript error: chrome://global/content/elements/checkbox.js, line 39: TypeError: this.delayConnectedCallback is not a function appears

Status: RESOLVED INVALID

(Thunderbird :: Untriaged, defect)

Description

[Jon Cutting]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Opened the settings page for an add-on which contains xul checkboxes

Actual results:

Javascript errors appeared in the terminal where I had launched Thunderbird, and the settings window failed to run its own JS

Expected results:

No errors and a populated settings window

Comment 1

[Jon Cutting]

This was the addon - https://addons.thunderbird.net/en-US/thunderbird/addon/sugarcrm-thunderbird-integr/

Comment 2

[Wayne Mery (:wsmwk)]

You are aware you likely need to make changes to your addon in order to work in beta?

Comment 3

[Jon Cutting]

Yes the add-on has been updated and it worked with beta version 66.

The checkbox error started appearing only after upgrade to version 67.

Comment 4

[Geoff Lankow (:darktrojan)]

You're going to need to make further changes, our preferences code has changed.

I also see this message, which probably needs fixing:

Error opening input stream (invalid filename?): chrome://opacustep/content/opacustep-createCustom.js

Comment 5

[Wayne Mery (:wsmwk)]

A great place for asking questions about add-ons is https://discourse.mozilla.org/c/thunderbird/addons

Comment 6

[Jon Cutting]

I've been developing this add on for a long time now and believe me I wouldn't waste your time submitting a bug unless there really was one.

This doesn't just affect the preferences window - all other modals are also affected.

The error also does not seem to be related to prefs:

"JavaScript error: chrome://global/content/elements/checkbox.js, line 40: TypeError: this.delayConnectedCallback is not a function"

I'm also not sure Geoff tested the latest version of the extension (1.0.6) as the error he mentions for createCustom.js was removed after 1.0.5, and the pref window was completely overhauled to use tabs instead of prefwindow as detailed in the linked article.

Comment 7

[Wayne Mery (:wsmwk)]

np. i'm must the middleman.

Comment 8

[Geoff Lankow (:darktrojan)]

How can I test the latest version when I have no link to it?

Comment 9

[Jon Cutting]

Attachment: opacustep-tbird67-1.0.6.xpi

Latest build for Thunderbird Beta

Comment 10

[Jon Cutting]

Sorry Geoff 1.0.5 also had the preferences update, but I've uploaded 1.0.6 against this bug.

Comment 11

[Jon Cutting]

I've tracked this down to the code that creates a checkbox using document.createElement

    for(var i in opacustep.searchableModules)
    {
        var row = document.createElement('richlistitem');
        var cell = document.createElement('listcell');
        var checkbox = document.createElement('checkbox');
        checkbox.setAttribute('label',opacustep.moduleLabels[opacustep.searchableModules[i]]);
        checkbox.setAttribute('id',opacustep.searchableModules[i]);
        row.setAttribute('allowevents','true');

        for(var j in this.selectedModules){
            if(this.selectedModules[j] == opacustep.searchableModules[i]){
                checkbox.setAttribute('checked','true');
            }
        }
        cell.appendChild(checkbox);
        row.appendChild(cell);
        this.searchWindow.document.getElementById('moduleList').appendChild(row);
    }

The error is triggered when adding the row to the DOM.