Closed Bug 1542221 Opened 1 year ago Closed 1 year ago

Profile manager does not remember the previous choices

Categories

(Toolkit :: Startup and Profile System, defect, P1)

All
Windows
defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
thunderbird_esr60 --- unaffected
geckoview66 --- unaffected
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 + verified
firefox68 --- verified

People

(Reporter: ccomorasu, Assigned: mossop)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • Fx 67.0b8
  • Fx 68.0a1

Affected platforms

  • Windows 10 x64

Steps to reproduce

  1. Go to the folder where the build is installed and open the commander.
  2. Type: "firefox.exe -p".
  3. Check/Uncheck the "Use the selected profile without asking at startup"
  4. Close the Profile Manager.
  5. Type again in the commander the following string: "firefox.exe -p".

Expected result

  • Profile Manager remembers the user choice.

Actual result

  • Profile Manager does not remember the user choice.

Regression range

Additional notes

  • Fx 67.0b7 is not affected.
Has Regression Range: --- → no
Has STR: --- → yes
Has Regression Range: no → yes
Assignee: nobody → dtownsend
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/707da9fd9d95
Correctly save the state of nsIToolkitProfileService.startWithLastProfile. r=Gijs
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

I'd like to see it verified on nightly.
Dave could you prepare an uplift to beta please? Thanks

Flags: qe-verify+
Flags: needinfo?(dtownsend)
Priority: -- → P1

(In reply to Pascal Chevrel:pascalc from comment #5)

I'd like to see it verified on nightly.
Dave could you prepare an uplift to beta please? Thanks

The existing patch aspplies directly to beta.

Flags: needinfo?(dtownsend)

(In reply to Dave Townsend [:mossop] (he/him) from comment #6)

(In reply to Pascal Chevrel:pascalc from comment #5)

I'd like to see it verified on nightly.
Dave could you prepare an uplift to beta please? Thanks

The existing patch aspplies directly to beta.

OK, but we need a formal uplift request on this patch to have it on relman and sheriffs radar and to have good bug history for our machine learning tools :)

(In reply to Pascal Chevrel:pascalc from comment #7)

(In reply to Dave Townsend [:mossop] (he/him) from comment #6)

(In reply to Pascal Chevrel:pascalc from comment #5)

I'd like to see it verified on nightly.
Dave could you prepare an uplift to beta please? Thanks

The existing patch aspplies directly to beta.

OK, but we need a formal uplift request on this patch to have it on relman and sheriffs radar and to have good bug history for our machine learning tools :)

Sorry, thought your comment meant you wanted to wait till it was verified on nightly before then.

Comment on attachment 9056642 [details]
Bug 1542221: Correctly save the state of nsIToolkitProfileService.startWithLastProfile. r=Gijs

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1527704
  • User impact if declined: User won't be able to switch between showing the profile manager on startup or not.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Extremely simple fix to a stupid mistake. Well tested. No risk to taking this at all.
  • String changes made/needed:
Attachment #9056642 - Flags: approval-mozilla-beta?

I can confirm this issue is fixed, I verified using Fx 68.0a1(2019-04-09), on Windows 10 x64.

Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Flags: qe-verify+

Comment on attachment 9056642 [details]
Bug 1542221: Correctly save the state of nsIToolkitProfileService.startWithLastProfile. r=Gijs

Low risk patch with tests for a P1 regression in 67 and verified by QA on Nightly, uplift approved for 67 beta 10, thanks Dave!

Attachment #9056642 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I can confirm this issue is no longer reproducible. I verified using Fx 67.0b10 on Windows 10 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.