1542272 - 0.17% Base Content JS (osx-10-10-shippable) regression on push 82630420613d2471e10454fab09129337ce4a2a4 (Thu Apr 4 2019)

Status: RESOLVED WONTFIX

(Core :: JavaScript: Internationalization API, defect)

Description

[Florin Strugariu [:Bebe]]

We have detected an awsy regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=82630420613d2471e10454fab09129337ce4a2a4

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

0% Base Content JS osx-10-10-shippable opt 4,002,916.00 -> 4,009,856.00

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=20317

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/AWSY/Tests

Comment 1

[Ionuț Goldan [:igoldan]]

This regression is too small for us to consider it. We only track regressions >2%.

Comment 2

[Eric Rahm [:erahm]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #1)

This regression is too small for us to consider it. We only track regressions >2%.

We intentionally track small regressions for the 'Base Content JS' measurement. Waldo or anba should at least look at this.

Comment 3

[André Bargull [:anba]]

I did some try-builds to find out which part of the patch is responsible for the size regression:

1. Commenting out the added calls: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b00d525c6a28ba51094fcba9a705c9f0043fdca [https://treeherder.mozilla.org/perf.html#/graphs?timerange=604800&series=try,1961195,1,4&selected=try,1961195,455869,773821478,4])
2. Commenting out the added functions: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fe80e0e5168b049f9568ad9cd13d2faf20c6642 [https://treeherder.mozilla.org/perf.html#/graphs?timerange=604800&series=try,1961195,1,4&selected=try,1961195,455882,773882770,4]

And from what I can see, simply adding new self-hosted functions caused the size regression, which means this is a Won't Fix, given that we're going to add (and sometimes remove) self-hosted functions all the time. Does that look correct?

Comment 4

[Eric Rahm [:erahm]]

(In reply to André Bargull [:anba] from comment #3)

And from what I can see, simply adding new self-hosted functions caused the size regression, which means this is a Won't Fix, given that we're going to add (and sometimes remove) self-hosted functions all the time. Does that look correct?

Thanks, that makes sense. tcampbell is looking at ways we can share self-hosted code, so in the future this should be less of an issue. I'm okay with WONTFIX.