1542342 - SpecialPowers.executeSoon should dispatch to the end of the task queue

Status: RESOLVED INVALID

(Core :: XPConnect, enhancement)

Description

[Will Hawkins]

In order to use executeSoon to put off execution of a function until all previous entries in the queue are executed, executeSoon should enqueue the task at the end of the queue (using NS_DISPATCH_AT_END).

Comment 1

[Bobby Holley (:bholley)]

I don't follow. Changing event ordering for executeSoon is likely to break tons of stuff, and also, NS_DISPATCH_AT_END does not change event ordering [1].

[1] https://searchfox.org/mozilla-central/rev/8e0ea968308dd692ba5394b14e584234acf7d4ca/xpcom/threads/nsIEventTarget.idl#43

Comment 2

[Will Hawkins]

This is just for SpecialPowers and I did not mean to imply that I wanted to change the semantics of the other definitions of executeSoon.

That said, I just read the comment you referenced and I think that I see your point. That said, I have tested before/after and this fixes the necessary intermittent timing failures that I was seeing.

If you don't mind, let me submit a patch and see what you think? Can I add you as a reviewer in phab?

Thank you for your quick response. I hope that this isn't a waste of your time.

Comment 3

[Will Hawkins]

Attachment: Bug 1542342: Update SpecialPowers.executeSoon to enqueue the task after all exiting entries. r=bholley

Comment 4

[Bobby Holley (:bholley)]

Discussed on a call.

Comment 5

[Will Hawkins]

Marking as invalid. Turns out this change is not necessary. Sorry for the confusion!