1542347 - fix some string flattening bits in security/manager/

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1542347 - eliminate needless string flattening in nsKeygenFormProcessor; r=keeler

We flatten an nsAString before calling GetPublicKey, but GetPublicKey
doesn't actually care about whether the string is null-terminated or
not. Let's save a tiny amount of work by not doing the flattening.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1542347 - eliminate needless string flattening in OSReauthenticator; r=keeler

We already have a null-terminated nsString in this code; we don't need
to turn it into another null-terminated nsString.

Depends on D26355

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: Bug 1542347 - remove nsPromiseFlatString.h includes from security/manager/; r=keeler

We include this header all over the place, but after the previous
patches, we never call any functions from the header.

Depends on D26356

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06b2ae4f86bc
eliminate needless string flattening in nsKeygenFormProcessor; r=keeler
https://hg.mozilla.org/integration/autoland/rev/eade880c4185
eliminate needless string flattening in OSReauthenticator; r=keeler

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/06b2ae4f86bc
https://hg.mozilla.org/mozilla-central/rev/eade880c4185