fix some string flattening bits in security/manager/

RESOLVED FIXED in Firefox 68

Status

()

defect
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

2 months ago
No description provided.
Assignee

Comment 1

2 months ago

We flatten an nsAString before calling GetPublicKey, but GetPublicKey
doesn't actually care about whether the string is null-terminated or
not. Let's save a tiny amount of work by not doing the flattening.

Assignee

Comment 2

2 months ago

We already have a null-terminated nsString in this code; we don't need
to turn it into another null-terminated nsString.

Depends on D26355

Assignee

Comment 3

2 months ago

We include this header all over the place, but after the previous
patches, we never call any functions from the header.

Depends on D26356

Attachment #9056194 - Attachment is obsolete: true

Comment 4

2 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06b2ae4f86bc
eliminate needless string flattening in nsKeygenFormProcessor; r=keeler
https://hg.mozilla.org/integration/autoland/rev/eade880c4185
eliminate needless string flattening in OSReauthenticator; r=keeler
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.