Closed Bug 1542349 Opened 5 years ago Closed 5 years ago

Add new devtools event probes to Amplitude

Categories

(Data Platform and Tools :: General, enhancement)

enhancement
Not set
normal
Points:
1

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tdsmith, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Sole let me know that the Devtools team has new event probes for the new remote debugging tool and asked me to help them assess them. Can we get these into Amplitude?

Julian provided Sole this list of methods in the devtools.main category:

close_adbg
open_adbg
device_added
device_removed
runtime_added
runtime_connected
runtime_disconnected
runtime_removed
select_page
show_profiler
update_conn_prompt
inspect

Type: defect → enhancement

It would be nice to get those in before the end of 68, so that we can see if our events need adjusting before we ship. Is there anything we can do to help?

Flags: needinfo?(tdsmith)

Hey Sunah, any thoughts?

Flags: needinfo?(tdsmith) → needinfo?(ssuh)

I need a couple more details:

  • The full event spec is category/method/object -- looks like the list here is "method" and all the objects are "aboutdebugging", is that correct?

  • Is there anything in the "value" field that I should be concerned about in any of these events?

  • Should I send all of the "extra_keys" specified in each of the events?

Assignee: nobody → ssuh
Points: --- → 1
Flags: needinfo?(ssuh) → needinfo?(jdescottes)

Thanks Sunah, that's correct:

  • "devtools.main" is the category
  • "method" is what was in the list
  • "object" is always "aboutdebugging"
  • "value" is always null
  • "extra_keys" should all be sent, for all events
category method object
devtools.main close_adbg aboutdebugging
devtools.main device_added aboutdebugging
devtools.main device_removed aboutdebugging
devtools.main inspect aboutdebugging
devtools.main open_adbg aboutdebugging
devtools.main runtime_added aboutdebugging
devtools.main runtime_connected aboutdebugging
devtools.main runtime_disconnected aboutdebugging
devtools.main runtime_removed aboutdebugging
devtools.main select_page aboutdebugging
devtools.main show_profiler aboutdebugging
devtools.main update_conn_prompt aboutdebugging
Flags: needinfo?(jdescottes)

I've submitted a PR for review for this change, but if someone would like to take a look at the devtools_dev project in amplitude (april 15th data only -- the april 16th data is from an earlier version of the config that I ended up making changes to) for verification before I merge it in that'd probably be a good idea (ni? Tim since he reported the bug but please redirect as necessary)

Flags: needinfo?(tdsmith)

Julian, can you confirm the Amplitude representation is what you're expecting? Let me know if I can help.

Flags: needinfo?(tdsmith) → needinfo?(jdescottes)

Thanks for working on this!

I don't think I have access to DevTools_Dev on Amplitude, I only see DevTools_Prod. Or maybe I don't know how to navigate to DevTools_Dev? In any case I think I need your help :)

Flags: needinfo?(jdescottes) → needinfo?(tdsmith)

From the conversation in #devtools-amplitude I think this got taken care of.

Flags: needinfo?(tdsmith)

I see the events in prod amplitude now -- closing this as fixed. Please reopen if events don't show up correctly as they enter new channels (especially release, since we have two separate configs for prerelease vs release.)

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: Datasets: Events → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: