RDM Settings: Save settings on modal close, and remove Done button
Categories
(DevTools :: Responsive Design Mode, enhancement)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: victoria, Assigned: mtigley)
Details
Attachments
(1 file)
Now that we have the X button and ability to click outside the window, the Done button is unnecessary.
Everything else is looking amazing :D
|
||
Updated•5 years ago
|
|
|
||
Comment 1•5 years ago
|
||
The Done button is currently a hard requirement to apply the changes. This enhancement request would need us to always save when adjustments (e.g. checking/unchecking some devices) happen.
I think it would be a good thing to do :)
|
Reporter | |
Comment 2•5 years ago
•
|
||
Oh I see, totally missed this! Would it be possible to add save-on-check/uncheck in this cycle?
If not, we'd want to go in the other direction as a stop-gap: Make the Done button a large blue Save button, add a cancel button, and remove the X. (Possibly even more UI changes would be needed to reduce confusion with the Add Device buttons.)
|
Assignee | |
Comment 3•5 years ago
|
||
I looked at the code that saves the checked/unchecked devices and can confirm that removing the "Done" button and always saving when the modal is closed will be very easy to do. The only thing that requires a little more effort is fixing the tests :)
|
|
Reporter | |
Comment 4•5 years ago
|
||
Awesome to hear that :D. Thanks Micah!
|
|
Reporter | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a36c745e301 Remove the 'Done' button at the bottom of the device modal. r=gl
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•