Open Bug 1542383 Opened 1 year ago Updated 1 year ago

processFileChanges shouldn't be called for builtin location

Categories

(Toolkit :: Add-ons Manager, defect, P2)

defect

Tracking

()

People

(Reporter: mixedpuppy, Unassigned)

Details

see https://phabricator.services.mozilla.com/D25244#772041

sourceBundle is undefined or null.

suggestion from aswan:

untested, but something like this as the first line inside the "for (let location of ...)" loop
if (!location.enumerable) { continue; }

https://searchfox.org/mozilla-central/rev/8e0ea968308dd692ba5394b14e584234acf7d4ca/toolkit/mozapps/extensions/internal/XPIDatabase.jsm#2739

Dale, can you give that a spin in your patch and see if that addresses the issue?

Flags: needinfo?(dharvey)

Hey, gave that a shot but nope, test hangs if I delete my sourceBundle check and add that line

Flags: needinfo?(dharvey)

:aswan thoughts? Need to figure this out tomorrow so we can get something to unblock landing the search patches.

Flags: needinfo?(aswan)

:daleharvey says "and 1542383 seems maybe fixed, I took the fix out and havent seen that stack"

I'll keep this open a bit longer, but removing it as blocking.

No longer blocks: 1496075
Priority: P1 → P2

(In reply to Shane Caraveo (:mixedpuppy) from comment #3)

:aswan thoughts? Need to figure this out tomorrow so we can get something to unblock landing the search patches.

how can i reproduce this? pull all the bug 1496075 patches and run locally?

Flags: needinfo?(aswan)
You need to log in before you can comment on or make changes to this bug.