Closed Bug 1542428 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16251 - Get the preferred main size from a size-contained flex item's box.

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16251 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16251
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Get the preferred main size from a size-contained flex item's box.

Assuming 0 won't do in all cases, at least not for multicol, since we
have to take column-gap and column-width into account. With contain:size
we're supposed to pretend that a box has no contents, which doesn't
imply that we can ignore column-gap and column-width.

This only fixes it when the main axis is the inline axis. When it's the
block axis, it might be safe to return 0 (which is what we still do).

This improves the rendering of
css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-003.html
but we still fail.

Bug: 863454
Change-Id: I444f94321dc1b10741515d8527ed4fdd72e6a15e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552039
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648090}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdddd6c79ada
[wpt PR 16251] - Get the preferred main size from a size-contained flex item's box., a=testonly

https://hg.mozilla.org/mozilla-central/rev/cdddd6c79ada

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.