1542479 - Autocomplete: Allow multiple emails in SecondEmail property

Status: RESOLVED INVALID

(Thunderbird :: Address Book, enhancement)

Description

[John Bieling]

Attachment: autocompleteAllowMultipleEmails.patch

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.86 Safari/537.36

Steps to reproduce:

This is a proposal (incl. patch) to allow to specify multiple email addresses in "SecondEmail" (a.k.a. Additional Email) and make autocomplete aware of that.

The SecondEmail property of a contact is not used anywhere in Thunderbird except:

• the list view in the address book
• autocomplete

There are no rules regarding that property, the user can enter whatever he wants, for example a list of emails seperated by ", ". If he does that, autocomplete will bring up the entire string.

This patch adds a check, if for a given directory the StringValue "autoComplete.secondEmailSeperator" is set and if so, uses that to split up the results.

It does not change the default behaviour.

I need that for TbSync/DAV to support multiple email addresses (as allowed by the CardDAV standard) without a major rewrite of the address book.

It is not possible to add that feature from the AddOn.

Comment 1

[John Bieling]

[:Fallen] Can you assign this to [e-mail]? The user [e-mail] is an old unused account of mine (which I totally forgot that it exists). It looks like I am not able to do that on my own.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9056322 [details] [diff] [review]
autocompleteAllowMultipleEmails.patch

Review of attachment 9056322 [details] [diff] [review]:
-----------------------------------------------------------------

[commit messages start like "Bug 1542479 - allow ...."

I think this breaks ever using the second email for something. Stuff like
https://searchfox.org/comm-central/rev/b5d1787ddc4335986c283c10b49ce752c79e7cae/mailnews/addrbook/src/nsAbCardProperty.cpp#483

::: mailnews/addrbook/src/nsAbAutoCompleteSearch.js
@@ +198,5 @@
>      }
>  
>      // Cache this values to save going through xpconnect each time
>      var commentColumn = this._commentColumn == 1 ? directory.dirName : "";
> +    var secondEmailSeperator = directory.getStringValue("autoComplete.secondEmailSeperator", "");

don't know where this is coming from. there's no such thing as autoComplete.secondEmailSeperator
And if there was something, it should probably be ","

Comment 3

[John Bieling]

I think this breaks ever using the second email for something. Stuff like
https://searchfox.org/comm-central/rev/b5d1787ddc4335986c283c10b49ce752c79e7cae/mailnews/addrbook/src/nsAbCardProperty.cpp#483

I did not find that beforehand. For me it looked like as there are no rules defined for SecondEmail. So this cannot be merged. I need to find another way to get this done.