1542484 - warnings when creating new News account

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[:aceman]

Creating new News account I get these warnings in the console:
ReferenceError: reference to undefined property "newsserver" in aw-incoming.js:69:7

ReferenceError: reference to undefined property "ServerType-nntp"AccountWizard.js:455:1

Comment 1

[:aceman]

Attachment: 1542484.patch

The pageData.newsserver.hostname is set only when you got Back in the wizard and then go Next, so the input is repopulated from this variable. So for the first visit of the page, pageData.newsserver.hostname is empty, so handle that cleanly.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9056331 [details] [diff] [review]
1542484.patch

Review of attachment 9056331 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/AccountWizard.js
@@ +450,5 @@
>  
> +    // See if there are any protocol-specific attributes.
> +    // If so, we use the type to get the IID, QueryInterface
> +    // as appropriate, then copy the data over.
> +    let serverAttrs = (("ServerType-" + srcServer.type) in srcServer) ?

Maybe a local variable here?

@@ +452,5 @@
> +    // If so, we use the type to get the IID, QueryInterface
> +    // as appropriate, then copy the data over.
> +    let serverAttrs = (("ServerType-" + srcServer.type) in srcServer) ?
> +                      srcServer["ServerType-" + srcServer.type] : null;
> +    dump("srcServer.ServerType-" + srcServer.type + " = " + serverAttrs + "\n");

Use dump(` ... `) here.

Comment 3

[:aceman]

Attachment: 1542484.patch v2

Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e07c8f10fbcb
fix some warnings when creating a News account. r=jorgk