Make nsDocShell use mozilla::PresShell directly rather than via nsIPresShell
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•5 years ago
|
||
This patch makes nsDocShell::GetPresShell() and
nsDocShell::GetEldestPresShell() return mozilla::PresShell* and
some non-public methods use mozilla::PresShell* directly.
|
|
Assignee | |
Comment 2•5 years ago
|
||
bz:
Sorry for the spam if you realized my multiple pings, but I really want to land this tomorrow morning and land other patches which depend on this patch one by one, since they are too big. So, the patches may break others' patches. Therefore, I'd like to land them in this weekend. So, could you give me r+ for the patch with where I should change?
|
||
Comment 3•5 years ago
|
||
Sorry for the lag; I did see the other ping too, but I was swamped with a few other things for a day. :(
I've marked the review now.
|
|
Assignee | |
Comment 4•5 years ago
|
||
bz:
Thank you very much and I know you are one of busiest people at Mozilla. But I want to land the big patches in this weekend separately for the other developers. So, really sorry for pinging you a lot.
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/c1a9e74c1b4b Make nsDocShell use mozilla::PresShell* directly rather than nsIPresShell* r=bzbarsky
|
|
||
Comment 6•5 years ago
|
||
No need to apologize! I really had meant to get to this review before the swamping happened, but just wasn't moving fast enough...
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Description
•