Code clean-up: remove blanks from brackets in parameters and align if and for correctly.
Categories
(SeaMonkey :: General, enhancement)
Tracking
(Not tracked)
People
(Reporter: frg, Unassigned, NeedInfo)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
As noted in the review comments in Bug 1540438:
If and for are sometimes missing a blank before the opening bracket and need to be aligned correctly in some files.
function parameters and expressions have spaces before and after the closing and opening bracket in some files
and maybe some other things can be improved too.
+++ This bug was initially created as a clone of Bug #1540438 +++
Even after Bug 1530955 we still have a lot of tabs and some trailing blanks left.
|
Reporter | |
Comment 1•7 years ago
|
||
Something for a rainy weekend if nobody takes it away first.
|
||
Comment 2•7 years ago
|
||
Hi Frank_Rainer,
I would like to pick this up for refactoring.
|
|
Reporter | |
Comment 3•7 years ago
|
||
Saurabh_Pakhare, do you have set up a dev environmeint for compiling SeaMonkey or Thunderbird?
|
|
Reporter | |
Comment 5•7 years ago
|
||
Saurabh, sorry was a bit busy this week. If you want to fix it you need to set up a build environment and do a patch against comm-esr60. comm-central builds but is currently broken.
Thunderbird setup is here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Thunderbird_build
I have SeaMonkey build setup instructions for Windows. Email me if you need them.
|
||
Comment 6•7 years ago
|
||
Hi I am a new conributor and want to work on this bug. Has it already been solved? If not please assign me to solve this bug.
(In reply to Sachin Kumar Danisetty from comment #6)
Hi I am a new conributor and want to work on this bug. Has it already been solved? If not please assign me to solve this bug.
Do you have set up a dev environmeint for compiling SeaMonkey or Thunderbird?
What platform do you use? Windows? Linux? Version?
Is your TB just for comm-central or do you have comm-esr60 too?
|
|
||
Comment 10•7 years ago
|
||
I use Ubuntu 18.04, I've set up my TB environment for comm-central. If required, I will rebuild it.
|
|
Reporter | |
Comment 11•6 years ago
|
||
Sachin, the easiest way to do this is to set up eslint and enable it locally for SeaMonkey (see bug 1542636). Then you can use fix-type for the suite tree. comm-central is currently broken but builds. application is comm/suite. comm/mail is Thunderbird.
If you want to tackle this please add a patch and ask Ian Neal or me for review. We will assign the bug then.
If you have questions shott me an email.
Description
•