1542572 - Add more temporary logging to LocalStorageShutdownTimeout crash annotation

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, enhancement, P1)

Comment 1

[Jan Varga [:janv]]

I'd like to add more logging which would iterate over the global arrays / hashtables and collect persistence types, origin strings and maybe some additional stuff.
We need this info only for short period of time to get an idea what type of LocalStorage is causing this.
So we would be able to focus on exact areas in the code.

Anyway, I'll wait for UnsafePtr (bug 1539538) to see if that reveals something.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1542572 - Add more temporary logging to LocalStorageShutdownTimeout crash annotation; r=asuth

Comment 3

[Jan Varga [:janv]]

Andrew, do you think we don't need this anymore ?

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Not sure. Apologies, I reviewed this the other day but didn't hit submit and it got lost in my sea of tabs :(. (I now have a thing to help with that though. :)

If you think we need it, you should land it.

Comment 5

[Jan Varga [:janv]]

Yes, we should land this patch. I think the shutdown hangs are now greatly reduced, but not 100% fixed yet.

Comment 6

[Jan Varga [:janv]]

Attachment: data-request.txt

This data review request is very similar to bug 1542478.

Comment 7

[Chris H-C :chutten]

Comment on attachment 9071947 [details]
data-request.txt

Could you please update the documentation around this collection in CrashAnnotations.yaml? It doesn't have to be long, but it should contain at least the data we propose to collect.

Comment 8

[Jan Varga [:janv]]

Comment on attachment 9071947 [details]
data-request.txt

Ok, I added documentation for this.

Comment 9

[Chris H-C :chutten]

Comment on attachment 9071947 [details]
data-request.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [CrashAnnotations.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/crashreporter/CrashAnnotations.yaml).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jan Varga is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be336ab586b0
Add more temporary logging to LocalStorageShutdownTimeout crash annotation; r=asuth dr=chutten

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/be336ab586b0