[META]Set up ESLint for SeaMonkey and fix up the source using it
Categories
(SeaMonkey :: General, task)
Tracking
(seamonkey2.53? affected)
People
(Reporter: frg, Assigned: frg)
References
(Depends on 1 open bug, )
Details
(Keywords: meta)
User Story
For comm-central setup lint: mach eslint --setup List potential issues (run in comm): ../mach lint -l eslint suite Autofix all (run in comm): ../mach lint -l eslint suite --fix Takes care of about 10000 but produces an unreviewable big patch. Needs to be broken down.
Attachments
(2 files)
|
156.65 KB,
application/x-zip-compressed
|
Details | |
|
526 bytes,
patch
|
Details | Diff | Splinter Review |
Formating in suite is inconsistent and there is currently no way to check new patches for conformity or simple errors. Given the fact that we more or less trail TB and Fx today we should use the same formating as the other products for easier porting and potential problem discovery.
TB has set up lint and code cleanup in mail and mailnews is still ongoing.
ESLint is currently disabled for suite. We should set it up in the long term.
Even with a broken c-c build the code is still mostly the same for esr60 which is not done yet so cleaning up c-c and backporting should be easy.
|
Assignee | |
Comment 1•5 years ago
|
||
With lint enabled around 19139 issues are reported. This need to be filtered and exceptions set up but most formatting issues are valid and easy to fix.
|
|
Assignee | |
Comment 2•5 years ago
|
||
quick and dirty patch to enable lint in local repos.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
Description
•