Fix issues found by mach static-analysis check

RESOLVED FIXED

Status

()

defect
P3
normal
RESOLVED FIXED
a month ago
22 days ago

People

(Reporter: longsonr, Assigned: longsonr)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(12 attachments, 1 obsolete attachment)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
Comment hidden (empty)
(Assignee)

Updated

a month ago
Assignee: nobody → longsonr
(Assignee)

Updated

a month ago
Keywords: leave-open
(Assignee)

Comment 3

a month ago

Part 2 is

cd dom/svg
sed -i "" "s|() {}|() = default;|" *.h

with a couple of changes reverted

Priority: -- → P3

Comment 4

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe062eac74d9
Part 1 - Correct namespace of forward declaration of DOMSVGAnimatedPreserveAspectRatio r=dholbert

Comment 5

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/323ed046cecd
Part 2 - Use default keyword instead of empty constructors and destructors r=dholbert

Comment 12

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f3de2533c4a
Part 3 - forward declaration of DOMSVGAnimatedNumberList is in the wrong namespace r=dholbert

Comment 13

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/550e2e142615
Part 4 - use nullptr rather than NULL r=dholbert

Comment 14

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f612b35ee514
Part 5 - don't use instance variables to access static methods r=dholbert

Comment 15

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c506542937a1
Part 6 - pass by reference when it's more efficient r=dholbert
(Assignee)

Comment 18

a month ago

Part 8 is mechanical i.e.

sed -i "" "s/std::move(atts)/atts/" SVGFE*.cpp

Comment 21

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/323cc63a9c2d
Part 7 - use default keyword where possible r=dholbert
Attachment #9058079 - Attachment is obsolete: true

Comment 23

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb46f41277c
Part 9 - Fix else after return r=dholbert

Comment 24

a month ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f243d937420
Part 10 - simplify boolean logic r=dholbert

Comment 28

26 days ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fc36dfcb6cf
Part 11 - add explicit to constructor r=dholbert

Comment 29

25 days ago
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3638ca566d88
Part 11 - add explicit to constructor r=dholbert

Comment 32

25 days ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12a4b6b72645
Part 12 - avoid implicit double to float conversions by using std:: variants of mathematical functions r=dholbert

Comment 35

23 days ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1181d18ea08c
Part 13 - Make function declaration and definition parameter names match r=dholbert
(Assignee)

Comment 37

22 days ago

I've not fixed everything but this is probably enough for one bug.

Status: NEW → RESOLVED
Last Resolved: 22 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.