Any methods shouldn't take `const nsCOMPtr<nsIPresShell>&` (we can use MOZ_CAN_RUN_SCRIPT instead)

RESOLVED FIXED in Firefox 68

Status

()

Product:
Core
Component:
General
Type:
defect
Importance:
P2
normal
Status:
RESOLVED FIXED
Opened:
4 months ago
Updated:
4 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Version:
Trunk
Target:
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Bug 1542665 - Stop using `const nsCOMPtr<nsIPresShell>&` arguments
47 bytes, text/x-phabricator-request
Details | Review

Some methods take const nsCOMPtr<nsIPresShell>& as their argument to make
their callers guarantee the lifetime. However, currently all of them are
marked as MOZ_CAN_RUN_SCRIPT. So, it's safe to change them to raw pointer.

Additionally, this patch makes them take mozilla::PresShell* directly
rather than via nsIPresShell*.

Priority: -- → P2
Attachment #9056446 - Attachment description: Bug 1542665 - Any methods shouldn't take `const nsCOMPtr<nsIPresShell>&` → Bug 1542665 - Stop using `const nsCOMPtr<nsIPresShell>&` arguments
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/34d443292062
Stop using `const nsCOMPtr<nsIPresShell>&` arguments r=bzbarsky

https://hg.mozilla.org/mozilla-central/rev/34d443292062

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.