Closed
Bug 1542665
Opened 2 years ago
Closed 2 years ago
Any methods shouldn't take `const nsCOMPtr<nsIPresShell>&` (we can use MOZ_CAN_RUN_SCRIPT instead)
Categories
(Core :: General, defect, P2)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•2 years ago
|
||
Some methods take const nsCOMPtr<nsIPresShell>&
as their argument to make
their callers guarantee the lifetime. However, currently all of them are
marked as MOZ_CAN_RUN_SCRIPT
. So, it's safe to change them to raw pointer.
Additionally, this patch makes them take mozilla::PresShell*
directly
rather than via nsIPresShell*
.
Updated•2 years ago
|
Priority: -- → P2
Updated•2 years ago
|
Attachment #9056446 -
Attachment description: Bug 1542665 - Any methods shouldn't take `const nsCOMPtr<nsIPresShell>&` → Bug 1542665 - Stop using `const nsCOMPtr<nsIPresShell>&` arguments
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/34d443292062 Stop using `const nsCOMPtr<nsIPresShell>&` arguments r=bzbarsky
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•