Closed
Bug 1542669
Opened 5 years ago
Closed 5 years ago
LSNG: GetItem, SetItem, RemoveItem should pass the key when creating a new snapsot
Categories
(Core :: Storage: localStorage & sessionStorage, enhancement, P2)
Core
Storage: localStorage & sessionStorage
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This is similar to bug 1513915. Currently, when we prefill a new snapshot with initial items, we ignore the key which actually triggered snapshot creation, so it can happen that there must be additional sync LoadItem call after snapshot creation. We can optimize this.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•5 years ago
|
||
I have a patch for this, will send it soon.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad73e5604411 LSNG: GetItem, SetItem, RemoveItem should pass the key when creating a new snapsot; r=asuth
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Comment 6•5 years ago
|
||
Backed out for causing bug 1549362.
https://hg.mozilla.org/mozilla-central/rev/df3eadfa74a8061f4c88496404d51baf47e21070
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla68 → ---
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4294ffae23f6 LSNG: GetItem, SetItem, RemoveItem should pass the key when creating a new snapsot; r=asuth
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•