1542713 - Remove search reset preferences and remaining code

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Mark Banner (:standard8)]

From bug 1521725 comment 13 (with updated links):

FYI ...

• _isWhiteListed doesn't seem to be used anymore either (see [1] and [2])
• the pref browser.search.reset.whitelist looks unused as well and can be removed from all.js (see [3])
• ideally browser.search.reset.status could be reset in a migration block in BrowserGlue.jsm because it was set there for if (currentUIVersion < 59)
• browser.search.reset.enabled is still used in 2 xpcshell tests (see [4]) but I don't know if that actually does anything anymore. If not, then that pref could be removed from firefox.js and all.js (see [4])

Thanks

[1] https://hg.mozilla.org/mozilla-central/file/7444d00f6a08/toolkit/components/search/SearchService.jsm#l2302
[2] https://searchfox.org/mozilla-central/search?q=_isWhiteListed&case=false&regexp=false&path=
[3] https://searchfox.org/mozilla-central/search?q=reset.whitelist&case=false&regexp=false&path=
[4] https://searchfox.org/mozilla-central/search?q=reset.enabled&case=false&regexp=false&path=

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1542713 - Remove search reset preferences and remaining code. r?mikedeboer,daleharvey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6e9facabd57
Remove search reset preferences and remaining code. r=daleharvey

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c6e9facabd57