1542734 - Rule view auto-corrects named CSS colors with mixed case to lowercase

Status: NEW

(DevTools :: Inspector: Rules, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: rules_mixed_upPerCaseLoWerCase.png

Affected versions

• 66.0.2, 67.0b8, 68.0a1 (2019-04-07);

Affected platforms

• Windows 10, macOS 10.14, Ubuntu 16.04

Steps to reproduce

1. Launch Firefox, enable the devTools inspector with the Rules section and Changes tab being displayed;
2. In the rules inspector, for any rule type the following line:
   color: rEd;
3. Press the Enter key;

Expected result

• the text format should remain the same (color: rEd;);

Actual result

• the text format is all lowercase letters (color: red;);

Regression range

• First bad build_date: 2018-12-06 09:33:31.527000 changeset: eeddd827762d17b290ffe65d17baf6196477f488
• Last good build_date: 2018-12-06 06:33:30.298000 changeset: ddd8bdd2f05e27159720709f8dd40a7d9dd006f6
• Pushlog: link
• Potential regressor: bug 1284852;

Additional notes

• attache screenshot with the issue;
• the Changes tab keeps the formatting as-is;

Comment 1

[Cristian Fogel [:cfogel]]

Hey Patrick, mind taking a look at this and confirming if it's the case?
Thanks!

Comment 2

[Patrick Brosset <:pbro>]

Yes I can confirm the bug. Indeed we do want to show "authored" styles in the Rules view as much as we can, so we should preserve the mixed case here. The regressor seems likely.
The Changes panel just listens to changes being made in the rule-view so ends up storing the right spelling. But the Rules view transforms the value because it's a color, so a special one. The code that does this likely converts color names.

Adjusting the tracking flags. I don't think this is bad enough that we want to attempt an uplift.