1542740 - Use AttachDecision in more IR generators for CacheIR.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Iain Ireland [:iain]]

While working on call ICs in bug 1533890, I introduced an AttachDecision enum to simplify tryAttachStub, instead of having multiple mutually exclusive boolean out-params. We should consider using the same pattern for other IR generators.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Add TRY_ATTACH macro and new versions of TryAttach templates r=mgaudet

This patch lays the groundwork for the stack.

To make it possible to switch everything over incrementally, I renamed the existing TryAttachStub/TryAttachIonStub templates, and added a new version. The old version gets deleted later in the stack when all the consumers have been fixed up.

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert GetPropIRGenerator to use AttachDecision r=mgaudet

This is one of the two non-trivial conversions. GetProp supports TemporarilyUnoptimizable, but not Deferred.

Note: I deleted a comment in IonGetPropertyIC::update that has been obsolete since bug 1383777: https://bugzilla.mozilla.org/show_bug.cgi?id=1383777#c2

Depends on D27297

Comment 3

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert GetNameIRGenerator to use AttachDecision r=mgaudet

Depends on D27298

Comment 4

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert BindNameIRGenerator to use AttachDecision r=mgaudet

Depends on D27299

Comment 5

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert HasPropIRGenerator to use AttachDecision r=mgaudet

Depends on D27300

Comment 6

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert InstanceOfIRGenerator to use AttachDecision r=mgaudet

Depends on D27301

Comment 7

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert TypeOfIRGenerator to use AttachDecision r=mgaudet

Depends on D27302

Comment 8

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert GetIteratorIRGenerator to use AttachDecision r=mgaudet

Depends on D27303

Comment 9

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert CompareIRGenerator to use AttachDecision r=mgaudet

Depends on D27304

Comment 10

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert ToBoolIRGenerator to use AttachDecision r=mgaudet

Depends on D27305

Comment 11

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert GetIntrinsicIRGenerator to use AttachDecision r=mgaudet

Depends on D27306

Comment 12

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert UnaryArithIRGenerator to use AttachDecision r=mgaudet

Depends on D27307

Comment 13

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert BinaryArithIRGenerator to use AttachDecision r=mgaudet

Depends on D27308

Comment 14

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert NewObjectIRGenerator to use AttachDecision r=mgaudet

This was the last consumer of the old implementation of TryAttachStub/TryAttachIonStub. This patch removes the transitional version.

Depends on D27309

Comment 15

[Iain Ireland [:iain]]

Attachment: Bug 1542740: Convert SetPropIRGenerator to use AttachDecision r=tcampbell

This is the other patch with non-trivial refactoring. (GetPropIRGenerator was the first.)

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1140aa6cfb40
Add TRY_ATTACH macro and new versions of TryAttach templates r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/f3c7978228c0
Convert GetPropIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3169b44fe327
Convert GetNameIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b9871f6c9a35
Convert BindNameIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/448eb3cd7fdf
Convert HasPropIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1e1017253de5
Convert InstanceOfIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/f96d9bb86997
Convert TypeOfIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ec38ecf241e2
Convert GetIteratorIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ffd868dfa8b1
Convert CompareIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/cd4e0264ddea
Convert ToBoolIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/f5d29f943027
Convert GetIntrinsicIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/94bdb9f0377a
Convert UnaryArithIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c9e126b6fe3d
Convert BinaryArithIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/7a8e62330019
Convert NewObjectIRGenerator to use AttachDecision r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/85d43344501f
Convert SetPropIRGenerator to use AttachDecision r=tcampbell

Comment 17

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1140aa6cfb40
https://hg.mozilla.org/mozilla-central/rev/f3c7978228c0
https://hg.mozilla.org/mozilla-central/rev/3169b44fe327
https://hg.mozilla.org/mozilla-central/rev/b9871f6c9a35
https://hg.mozilla.org/mozilla-central/rev/448eb3cd7fdf
https://hg.mozilla.org/mozilla-central/rev/1e1017253de5
https://hg.mozilla.org/mozilla-central/rev/f96d9bb86997
https://hg.mozilla.org/mozilla-central/rev/ec38ecf241e2
https://hg.mozilla.org/mozilla-central/rev/ffd868dfa8b1
https://hg.mozilla.org/mozilla-central/rev/cd4e0264ddea
https://hg.mozilla.org/mozilla-central/rev/f5d29f943027
https://hg.mozilla.org/mozilla-central/rev/94bdb9f0377a
https://hg.mozilla.org/mozilla-central/rev/c9e126b6fe3d
https://hg.mozilla.org/mozilla-central/rev/7a8e62330019
https://hg.mozilla.org/mozilla-central/rev/85d43344501f