1542776 - "Welcome screen" is displayed when opening external links

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: First Run, defect, P2)

Description

[Sorina Florean [:sflorean]]

Environment:
Device: Google Pixel(Android Q);
Build: Nightly 68.0a1 (2019-04-07);

Prerequisite:

• Make sure your Firefox profile is clean (Android Settings)

Steps to reproduce:

1. Launch Firefox through an external Intent (e.g. Gmail).
2. Long tap on any link on the page.

Expected result:
Firefox is launched and the website from the chosen link is displayed, welcome screen is missing.

Actual result:
"Welcome screen" is displayed. If "Start browsing" is tapped, a white page is visible.

Video:
https://drive.google.com/open?id=1N76bXRPwbwD1J5OawzpJbSgplGuBIBTU

Comment 1

[Petru-Mugurel Lingurar [:petru]]

For the first part - "Welcome screen is displayed.", from what I see in the app I think this is the intended behavior.
But as I understand there are QA tests for this so maybe we have a regression here and opening the app for the first time from an external link should not show the Onbording screens.

Regarding the second part - "If Start browsing is tapped, a white page is visible", I'd say this is the intended behavior. We are trying to open a link (that ci4.googleusercontent.com/....) that points to an image Fennec offers to download. But the page that redirects to this image is blank - https://drive.google.com/file/d/125eDT84Yog3acybn0lLGhV07TzoyPak3

This scenario can also be seen on Chrome - https://drive.google.com/file/d/1PaEqUcewxBvT-wrHx-0uBtlXVZE0DTVy

Comment 2

[Sorina Florean [:sflorean]]

Eliza, can you check for a regression window? Thanks

Comment 3

[Marcia Knous [:marcia]]

P2 based on triage discussion.

Comment 4

[Eliza Balazs]

Hi!

I tested this on Nokia 6 (Android 7.1.1) and I found a regression for this issue.

Last good revision: b07e69b0cf6ac9c099e6192d17d2079d093ac725
First bad revision: 84683bf540a58f9d3db645550748e37c742991d6

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b07e69b0cf6ac9c099e6192d17d2079d093ac725&tochange=84683bf540a58f9d3db645550748e37c742991d6

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1542776 - Don't show Onboarding if first opened from external link; r?AndreiLazar

..And ignore trying to show it again in future app starts.
This patch resolves a regression and restore the previous behavior.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7f6e6c1ca17
Don't show Onboarding if first opened from external link; r=AndreiLazar

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a7f6e6c1ca17

Comment 8

[Eliza Balazs]

Hi!

I tested this issue on the latest version of Nightly 68.0a1 (2019-04-14) with OnePlus 5T (Android 9), Samsung Galaxy Note 8 (Android 9) and I wasn't able to reproduce the issue.

Due to my findings, I'll mark this issue as verified on Firefox 68.

Thanks.