Closed
Bug 1542803
Opened 5 years ago
Closed 4 years ago
List cases for all prototypes in skipDeselectedConstructor
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: terpri, Assigned: tetsuharu)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
The switch statement in GlobalObject::skipDeselectedConstructor should have cases for all possible JSProtoKey values instead of using a default: case.
|
Reporter | |
Updated•5 years ago
|
Type: task → enhancement
Keywords: good-first-bug
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•5 years ago
|
||
I'll take this.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tetsuharu, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(tetsuharu.ohzeki)
|
|
Assignee | |
Comment 4•5 years ago
|
||
My previous patch was r+ by :jorendorff. But I needed to rebase it and so ask to review it to them.
So I did not land my patch (I seem that I need re-rebase my patch again on the latest mozilla-central).
Flags: needinfo?(tetsuharu.ohzeki)
|
||
Updated•4 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Pushed by tetsuharu.ohzeki@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1dae503220a1 List cases for all prototypes in skipDeselectedConstructor. r=jorendorff
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•