Closed Bug 1542803 Opened 3 years ago Closed 2 years ago

List cases for all prototypes in skipDeselectedConstructor

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: terpri, Assigned: tetsuharu)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

The switch statement in GlobalObject::skipDeselectedConstructor should have cases for all possible JSProtoKey values instead of using a default: case.

Type: task → enhancement
Keywords: good-first-bug
Priority: -- → P3

I'll take this.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tetsuharu, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(tetsuharu.ohzeki)

My previous patch was r+ by :jorendorff. But I needed to rebase it and so ask to review it to them.
So I did not land my patch (I seem that I need re-rebase my patch again on the latest mozilla-central).

Flags: needinfo?(tetsuharu.ohzeki)
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1dae503220a1
List cases for all prototypes in skipDeselectedConstructor. r=jorendorff
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.