1542907 - Should ignore multiple identical msids

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

In #media on irc today, we ran into an SFU based on webrtc.org 72 sending multiple msid lines with identical mids.

The spec here says:

"For each MSID in msids, unless a MediaStream object has previously been created with that id for this connection, create a MediaStream object with that id."

followed by "Let streams be a list of the MediaStream objects created for this connection with the ids corresponding to msids."

I interpret this to mean we should ignore duplicate ids, both when creating objects and when assembling a list of the resultant objects in streams.

So we should probably ignore duplicate identical msids, if we see them. Seemed theoretical until it happened for real.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1542907 - Part 0: Add test-case for duplicate msids. r?jib

Depends on D25799

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1542907 - Part 1: Remove duplicate msids. r?mjf

Depends on D27116

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ddba6b16c9725472ddbbfae63f110935b0d340a

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=675b8c786063d123e789d9ded7c747a93c459098

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96a069324e7b3b2f2d5878736b7c0ded47880df3

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c29b724494bb3e7e6087f949f9662664f23e358

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f80cad005ba
Part 0: Add test-case for duplicate msids. r=jib
https://hg.mozilla.org/integration/autoland/rev/3f1fac8a763c
Part 1: Remove duplicate msids. r=mjf

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0f80cad005ba
https://hg.mozilla.org/mozilla-central/rev/3f1fac8a763c

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16818 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged