Closed Bug 1542910 Opened 8 months ago Closed 8 months ago

Script and function compilation should return JSScript*/JSFunction* directly

Categories

(Core :: JavaScript Engine, task, minor)

task
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(2 files)

The current APIs return bool and return the JSScript* or JSFunction* by MutableHandle outparam. But the outparam's value always duplicates the meaning of the bool variable. These functions should just return the thing directly.

Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/79e4fd335dc6
Make JS::CompileFunction return a JSFunction* directly, instead of by outparam for no good reason.  r=arai
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/d470f958ea61
Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning.  r=arai
Flags: needinfo?(jwalden)
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/53e379a5738f
Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning.  r=arai
Backout by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9d09627acaf
Backed out changeset 53e379a5738f as requested by waldo on irc. CLOSED TREE
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/5c5765ae3e64
Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning.  r=arai
Flags: needinfo?(jwalden)
You need to log in before you can comment on or make changes to this bug.