Telemetry about captive portals
Categories
(Core :: Networking, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: dragana, Assigned: dragana)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
2.57 KB,
text/plain
|
chutten
:
data-review+
|
Details |
Assignee | ||
Comment 1•5 years ago
|
||
Collect telemetry, how often user are behind a captive portal and how much traffic goes through it.
Assignee | ||
Comment 2•5 years ago
|
||
Adding telemetry for the amount of traffic transfer over the captive portal. Also moving some telemetry for trackers to the same place where our old telemetry is, so that they are all on the same place.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Comment on attachment 9057995 [details] request.md Preliminary notes: The collections as defined in Scalars.yaml will only be recorded in pre-release channels (Nightly and Beta). The data collection review request asks for all channels so I will review the request. If you'd like to [update the definitions](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/scalars.html#optional-fields) to be collected on all channels, please go ahead. DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? No. This collection will expire in Firefox 73. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all release channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. Dragana is responsible for renewing or removing the collection before it expires in Firefox 73. --- Result: datareview+
Assignee | ||
Updated•5 years ago
|
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d969c3ed6999
Collect telemetry on traffic transferred through a captive portal. r=valentin
Comment 6•5 years ago
|
||
Backed out for assertion failures on netwerk/protocol/http/nsHttpHandler.cpp
backout: https://hg.mozilla.org/integration/autoland/rev/43d9bbc5d92cd6511481700068984476c6fdc238
push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d969c3ed6999b34bfaa1a23bb7db115076b7f760&group_state=expanded
failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241023267&repo=autoland&lineNumber=5783.
[task 2019-04-17T18:57:19.985Z] 18:57:19 INFO - TEST-START | dom/websocket/tests/test_websocket4.html
[task 2019-04-17T18:57:20.067Z] 18:57:20 INFO - GECKO(1815) | ++DOMWINDOW == 24 (0xdbcdb000) [pid = 1815] [serial = 96] [outer = 0xdb15f9b0]
[task 2019-04-17T18:57:20.393Z] 18:57:20 INFO - GECKO(1815) | Assertion failure: OnSocketThread() (not on socket thread), at /builds/worker/workspace/build/src/netwerk/protocol/http/nsHttpHandler.cpp:2726
[task 2019-04-17T18:58:02.854Z] 18:58:02 INFO - GECKO(1815) | #01: mozilla::net::nsHttpHandler::GetHttpTrafficAnalyzer() [netwerk/protocol/http/nsHttpHandler.cpp:2726]
[task 2019-04-17T18:58:02.854Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.856Z] 18:58:02 INFO - GECKO(1815) | #02: mozilla::net::nsHttpConnection::~nsHttpConnection() [netwerk/protocol/http/nsHttpConnection.cpp:174]
[task 2019-04-17T18:58:02.856Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.859Z] 18:58:02 INFO - GECKO(1815) | #03: <name omitted> [netwerk/protocol/http/nsHttpConnection.cpp:127]
[task 2019-04-17T18:58:02.859Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.860Z] 18:58:02 INFO - GECKO(1815) | #04: mozilla::net::nsHttpConnection::Release() [netwerk/protocol/http/nsHttpConnection.cpp:0]
[task 2019-04-17T18:58:02.860Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.860Z] 18:58:02 INFO - GECKO(1815) | #05: mozilla::net::ConnectionHandle::~ConnectionHandle() [netwerk/protocol/http/nsHttpConnectionMgr.cpp:1813]
[task 2019-04-17T18:58:02.860Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.861Z] 18:58:02 INFO - GECKO(1815) | #06: mozilla::net::ConnectionHandle::~ConnectionHandle() [netwerk/protocol/http/nsHttpConnectionMgr.cpp:1804]
[task 2019-04-17T18:58:02.861Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.862Z] 18:58:02 INFO - GECKO(1815) | #07: mozilla::net::ConnectionHandle::Release() [netwerk/protocol/http/nsHttpConnectionMgr.cpp:0]
[task 2019-04-17T18:58:02.862Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.863Z] 18:58:02 INFO - GECKO(1815) | #08: mozilla::net::nsHttpTransaction::~nsHttpTransaction() [netwerk/protocol/http/nsHttpTransaction.cpp:252]
[task 2019-04-17T18:58:02.863Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.863Z] 18:58:02 INFO - GECKO(1815) | #09: <name omitted> [netwerk/protocol/http/nsHttpTransaction.cpp:233]
[task 2019-04-17T18:58:02.864Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.864Z] 18:58:02 INFO - GECKO(1815) | #10: mozilla::net::nsHttpTransaction::DeleteSelfOnConsumerThread() [netwerk/protocol/http/nsHttpTransaction.cpp:2163]
[task 2019-04-17T18:58:02.864Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.865Z] 18:58:02 INFO - GECKO(1815) | #11: mozilla::net::nsHttpTransaction::Release() [netwerk/protocol/http/nsHttpTransaction.cpp:0]
[task 2019-04-17T18:58:02.865Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.866Z] 18:58:02 INFO - GECKO(1815) | #12: mozilla::net::nsHttpChannel::OnStopRequest(nsIRequest*, nsresult) [netwerk/protocol/http/nsHttpChannel.cpp:0]
[task 2019-04-17T18:58:02.866Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.867Z] 18:58:02 INFO - GECKO(1815) | #13: non-virtual thunk to mozilla::net::nsHttpChannel::OnStopRequest(nsIRequest*, nsresult) [netwerk/protocol/http/nsHttpChannel.cpp:0]
[task 2019-04-17T18:58:02.867Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.867Z] 18:58:02 INFO - GECKO(1815) | #14: nsInputStreamPump::OnStateStop() [netwerk/base/nsInputStreamPump.cpp:656]
[task 2019-04-17T18:58:02.868Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.868Z] 18:58:02 INFO - GECKO(1815) | #15: nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) [netwerk/base/nsInputStreamPump.cpp:412]
[task 2019-04-17T18:58:02.869Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.871Z] 18:58:02 INFO - GECKO(1815) | #16: non-virtual thunk to nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) [netwerk/base/nsInputStreamPump.cpp:0]
[task 2019-04-17T18:58:02.871Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.872Z] 18:58:02 INFO - GECKO(1815) | #17: nsInputStreamReadyEvent::Run() [xpcom/io/nsStreamUtils.cpp:91]
[task 2019-04-17T18:58:02.872Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.873Z] 18:58:02 INFO - GECKO(1815) | #18: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:0]
[task 2019-04-17T18:58:02.873Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.874Z] 18:58:02 INFO - GECKO(1815) | #19: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:486]
[task 2019-04-17T18:58:02.874Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.875Z] 18:58:02 INFO - GECKO(1815) | #20: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:89]
[task 2019-04-17T18:58:02.875Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.876Z] 18:58:02 INFO - GECKO(1815) | #21: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:315]
[task 2019-04-17T18:58:02.877Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.877Z] 18:58:02 INFO - GECKO(1815) | #22: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2019-04-17T18:58:02.878Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.878Z] 18:58:02 INFO - GECKO(1815) | #23: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
[task 2019-04-17T18:58:02.879Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.879Z] 18:58:02 INFO - GECKO(1815) | #24: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:270]
[task 2019-04-17T18:58:02.879Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.880Z] 18:58:02 INFO - GECKO(1815) | #25: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:4571]
[task 2019-04-17T18:58:02.880Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.881Z] 18:58:02 INFO - GECKO(1815) | #26: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:4709]
[task 2019-04-17T18:58:02.882Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.882Z] 18:58:02 INFO - GECKO(1815) | #27: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:4790]
[task 2019-04-17T18:58:02.883Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.883Z] 18:58:02 INFO - GECKO(1815) | #28: mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/Bootstrap.cpp:45]
[task 2019-04-17T18:58:02.884Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.885Z] 18:58:02 INFO - GECKO(1815) | #29: _fini
[task 2019-04-17T18:58:02.885Z] 18:58:02 INFO -
[task 2019-04-17T18:58:02.886Z] 18:58:02 INFO - GECKO(1815) | ExceptionHandler::GenerateDump cloned child 1930
[task 2019-04-17T18:58:02.886Z] 18:58:02 INFO - GECKO(1815) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2019-04-17T18:58:02.887Z] 18:58:02 INFO - GECKO(1815) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2019-04-17T18:58:02.906Z] 18:58:02 INFO - TEST-INFO | Main app process: exit 11
Assignee | ||
Updated•5 years ago
|
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2376c13c6b9
Collect telemetry on traffic transferred through a captive portal. r=valentin
Comment 8•5 years ago
|
||
bugherder |
Assignee | ||
Comment 9•5 years ago
|
||
Comment on attachment 9057994 [details]
Bug 1543005 - Collect telemetry on traffic transferred through a captive portal. r=valentin
Beta/Release Uplift Approval Request
- User impact if declined: this bug only collects telemetry about amount of traffic. We need it for a project.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It only collects telemetry.
- String changes made/needed: none
Comment 10•5 years ago
|
||
Dragana, have you verified that you are receiving this telemetry data on Nightly?
Assignee | ||
Comment 11•5 years ago
|
||
(In reply to Pascal Chevrel:pascalc from comment #10)
Dragana, have you verified that you are receiving this telemetry data on Nightly?
I was just looking at them. I will need to change limits for one of the probes. I will remove beta-uplift request for now.
Assignee | ||
Updated•5 years ago
|
Description
•