1543008 - Ctrl+Click on a link in the console shouldn't put it in the sidebar

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Evaluate ["visit https://mozilla.org now!"]
3. In the logged array, do Ctrl+Click (Cmd on OSX) on the link

Expected results

It opens the link in a background tab

Actual results

The link is opened as expected, but we are also opening the sidebar with the array in it.

---

We should stop the event propagation in devtools/client/webconsole/webconsole.js#146-157

Comment 1

[Chris DeLuca:bronzehedwick]

Hello! I'd like to start contributing to Firefox DevTools and this bug seems like a nice way to ease in. Could this be assigned to me?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Hello Chris, I assigned the bug to you.

You can follow http://docs.firefox-dev.tools/getting-started/ to setup the work environment.
Make sure to choose Artifact builds when asked as it's much faster.

Feel free to ask any question, either here or on Slack!

Comment 3

[Chris DeLuca:bronzehedwick]

Thanks so much Nicolas! I'm following the getting started guide now and will reach out if I have any trouble. Thanks again!

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Hello Chris, how is it going? Any trouble?

Comment 5

[Chris DeLuca:bronzehedwick]

Hi Nicolas, thanks for checking in! I did have some trouble cloning the repo and finding 40GB of space, but I think I solved that! Running the builds now. Sorry for the n00b slowness!

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

no worries, I only wanted to make sure everything was okay. Setting up the project is the hardest part!

Comment 7

[Chris DeLuca:bronzehedwick]

Hi Nicolas, I just wanted to update you that I've successfully built mozilla-central and have a bugfix. I'm still wrapping my head around the arc/moz-phab/mercurial workflow, but I think I'll be able to finally cross the finish line tomorrow evening after work.

Thanks for your patience!

Comment 8

[Chris DeLuca:bronzehedwick]

Attachment: Bug 1543008 - Prevent event propagation in OpenLink webconsole function. r=nchevobbe

Before this change, ctrl/cmd clicking a url in an array in the web
console also opened the sidebar. Preventing event propagation stop the
click from getting to sidebar opening function.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/643854893d69
Prevent event propagation in OpenLink webconsole function. r=nchevobbe

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/643854893d69