Closed Bug 1543008 Opened 2 years ago Closed 2 years ago

Ctrl+Click on a link in the console shouldn't put it in the sidebar


(DevTools :: Console, defect, P3)



(firefox69 fixed)

Firefox 69
Tracking Status
firefox69 --- fixed


(Reporter: nchevobbe, Assigned: bronzehedwick)




(Keywords: good-first-bug)


(1 file)

Steps to reproduce

  1. Open the console
  2. Evaluate ["visit now!"]
  3. In the logged array, do Ctrl+Click (Cmd on OSX) on the link

Expected results

It opens the link in a background tab

Actual results

The link is opened as expected, but we are also opening the sidebar with the array in it.

We should stop the event propagation in devtools/client/webconsole/webconsole.js#146-157

Hello! I'd like to start contributing to Firefox DevTools and this bug seems like a nice way to ease in. Could this be assigned to me?

Hello Chris, I assigned the bug to you.

You can follow to setup the work environment.
Make sure to choose Artifact builds when asked as it's much faster.

Feel free to ask any question, either here or on Slack!

Assignee: nobody → signups

Thanks so much Nicolas! I'm following the getting started guide now and will reach out if I have any trouble. Thanks again!

Hello Chris, how is it going? Any trouble?


Hi Nicolas, thanks for checking in! I did have some trouble cloning the repo and finding 40GB of space, but I think I solved that! Running the builds now. Sorry for the n00b slowness!

no worries, I only wanted to make sure everything was okay. Setting up the project is the hardest part!

Hi Nicolas, I just wanted to update you that I've successfully built mozilla-central and have a bugfix. I'm still wrapping my head around the arc/moz-phab/mercurial workflow, but I think I'll be able to finally cross the finish line tomorrow evening after work.

Thanks for your patience!

Before this change, ctrl/cmd clicking a url in an array in the web
console also opened the sidebar. Preventing event propagation stop the
click from getting to sidebar opening function.

Pushed by
Prevent event propagation in OpenLink webconsole function. r=nchevobbe
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
QA Whiteboard: [qa-69b-p2]
You need to log in before you can comment on or make changes to this bug.