Closed Bug 1543017 Opened 6 months ago Closed 6 months ago

Running JS tests on a remote machine generates 400KB/s network traffic

Categories

(Core :: JavaScript Engine, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

I was surprised to see such a large amount of network traffic while running jittests/jstests.

ProgressBar has an update_granularity() method but there's nothing to ensure that poke() doesn't get called more often than this, and this is what is happening.

Don't update the progress bar more than necessary by recording the last update time and checking in poke(). Network traffic is down to 12KB/s with this patch.

But but but I was using this for space-heater functionality! https://xkcd.com/1172/ (hovertext)

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16070c339499
Don't update test progress bar so often r=sfink
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.