1543023 - Cleanup usages of ChromeUtils.import

Status: RESOLVED FIXED

(DevTools :: General, task, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1540694 started cleaning up unnecessary complex usages of ChromeUtils.import().

In ancient times, this helper was called Components.utils.import() and used to pollute the global if the second argument was left empty. In order to prevent that we came up with unnecessary complex pattern where we passed an empty object or a temporary scope object.

ChromeUtils.import still supports the second argument in order to be able to refactor the codebase by pieces, but we should converge into a unified way of importing symbols. And it should look like this:

  const { Symbol } = ChromeUtils.import("resource://devtools/foo/bar.js");

or

  const Symbol = ChromeUtils.import("resource://devtools/foo/bar.js");

Comment 1

[Alexandre Poirot [:ochameau]]

Here is a couple of searchfox queries to find a few places to refactor:
https://searchfox.org/mozilla-central/search?q=ChromeUtils%5C.import%5C(%22%5B%5E%22%5D%2B%22%2C.*null&case=false&regexp=true&path=devtools
https://searchfox.org/mozilla-central/search?q=ChromeUtils%5C.import%5C(%22%5B%5E%22%5D%2B%22%2C.*%5C%7B%5C%7D&case=false&regexp=true&path=devtools
https://searchfox.org/mozilla-central/search?q=ChromeUtils%5C.import%5C(%22%5B%5E%22%5D%2B%22%2C.*tempScope&case=false&regexp=true&path=devtools

Comment 2

[Mark Banner (:standard8)]

Bug 1531368 is on file that references the extension manager cleanups.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1543023 - Use ChromeUtils.import only with one argument in all /devtools/

ChromeUtils.import still support a second argument as it used to do
when it was Components.utils.import. But this is deprecated and we should
instead always use the returned value.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cb7ce6210d2
Use ChromeUtils.import only with one argument in all /devtools/ r=jdescottes

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1cb7ce6210d2