1543058 - Only one page per site appears pinned when pinning multiple pages from a site

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Henri Sivonen (:hsivonen)]

Steps to reproduce

1. Visit two pages on one site, e.g. two distinct weather forecast URLs on one weather forecast site.
2. From the history view, pin both pages.

Actual results

Only one of the pages shows up as pinned, but both count towards the pinning quota of 8 pins.

Expected results

Expected both to show up pinned to the Top Sites view.

Comment 1

[Henri Sivonen (:hsivonen)]

This seems like a regression in the last few weeks.

Comment 2

[Matt Brubeck (:mbrubeck)]

Possibly a regression from bug 1506231.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Indeed, seems like a regression caused by bug 1506231. Thanks Matt!

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1543058 - Display all pinned top sites even with identical base URLs; r?VladBaicu

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c8359c8c110
Display all pinned top sites even with identical base URLs; r=VladBaicu

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1c8359c8c110

Comment 7

[Eliza Balazs]

Hello!

Verified as fixed on the latest version of Nightly 68.0a1 (2019-04-23) with Samsung Galaxy S8 (Android 9) and OnePlus 5T (Android 9).

Thanks!