1543172 - Update Snippets section in the about:preferences with a link

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, enhancement, P5)

Description

[Jean Collings]

Attachment: Screen Shot 2019-04-09 at 9.28.47 AM.png

Please update the about:preferences under the Snippets section with a "How it works" link: https://support.mozilla.org/kb/snippets-firefox-faq

We would like to update it similar to how it currently is for the Recommended by Pocket section and the "How it works" link (see attached screenshot).

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Hey Jean, is this part of an ongoing project? Is there a deadline that you're looking to get this fixed? If so, we should probably find an assignee (and link it to the ongoing project through the blocks/depends on field, if applicable).

Comment 2

[Jean Collings]

(In reply to (behind on needinfos) Jared Wein [:jaws] (please needinfo? me) from comment #1)

Hey Jean, is this part of an ongoing project? Is there a deadline that you're looking to get this fixed? If so, we should probably find an assignee (and link it to the ongoing project through the blocks/depends on field, if applicable)

Hi Jared, there is no deadline and it is not a part of any ongoing project. We just wanted to give our users more information about snippets if they ever wanted to know more.

Hope this helps, thank you!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Thanks Jean. Kate, would you like to mentor this bug? I found that the code for the Recommend by Pocket line is at one of these two places, https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/AboutPreferences.jsm#228-231,297-300, but I don't know how you do the localization here so I probably shouldn't mentor this bug.

Comment 4

[Kate Hudson :k88hudson]

Yep, happy to mentor this one!

Comment 5

[Rizwan Syed]

Hi, could you assign this bug to me please? Would like to work on it.

Comment 6

[Rizwan Syed]

Hi did anyone see my above message?

Comment 7

[Monika Maheshwari [:MonikaMaheshwari]]

Hi can I work on this issue?

Comment 8

[Anshul Sahai]

Hey. Can I take this one up?

Comment 9

[Henry Green [:harperG]]

(In reply to Anshul Sahai from comment #8)

Hey. Can I take this one up?

Sure. Do you still want it?

Comment 10

[Sukhmeet[:sukh]]

Hi, Is this still available?

Comment 11

[Henry Green [:harperG]]

(In reply to sukhmeet2002 from comment #10)

Hi, Is this still available?

What do you mean?

Comment 12

[Sukhmeet[:sukh]]

(In reply to hgreen.9 from comment #11)

(In reply to sukhmeet2002 from comment #10)

Hi, Is this still available?

What do you mean?

I wanted to ask if anyone else is working on this issue.

Comment 13

[Henry Green [:harperG]]

(In reply to sukhmeet2002 from comment #12)

(In reply to hgreen.9 from comment #11)

(In reply to sukhmeet2002 from comment #10)

Hi, Is this still available?

What do you mean?

I wanted to ask if anyone else is working on this issue.

ok. I think it is still free but I would just check with the mentor of the bug before you start working on it

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:jaws, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 15

[Abhishek[: unavailable till 11 May]]

Hi, I can work on this issue, and I have done some research to check whether I was right or not I want to confirm, I have to work on this file - mozilla-unified/browser/components/newtab/lib/AboutPreferences.jsm line - 58-70, Please guide me.

Comment 16

[Abhishek[: unavailable till 11 May]]

If I am on right track, then suggest me How I can make changes as it will be my first UI related task

Comment 17

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1543172 - Update Snippets section in the about:preferences with a link r?settings-reviewers

Comment 18

[Abhishek[: unavailable till 11 May]]

I have made changes, but I want to confirm whether I am on right track or not, It might also require some more changes, please have a look at my initial work and guide me accordingly

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D172355	Bug 1543172 - Update Snippets section in the about:preferences with a link r=Jean Collings	tiwari.abhishektiwari23	Jean: Inactive

:tiwari.abhishektiwari23, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Comment 20

[:Gijs (away/busy until Mar 10)]

Jared, can you get this unstuck? Do we still want this and if so, who could review the patch?

Comment 21

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hmm. This is a confusing situation: on one hand, this bug asks to add a link to a SUMO page, but that page says we are no longer supporting Snippets in Firefox as of version 89. On the other hand, the Snippets about:preferences checkbox is still there, and I see a lot of other snippets references in the source code.

I'm going to ask around and follow up. I'll leave the needinfo for now as a reminder.

Comment 22

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sorry, not sure how the status flags got flipped. Let's put those back.

Comment 23

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I've asked around on Slack, and discovered that we might want to pick Snippets back up at a future time, so this patch is still worth landing.

The right next step would be to request review from the settings-reviewers review group, so I've updated the phabricator revision to request a review from that group.

Sorry this patch got dropped, Abhishek! Please ping me if you have any other questions.

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 25

[Mike Conley (:mconley) (:⚙️)]

The Snippets capability, server endpoint, and Settings UI section, was removed in bug 1715158, so I think we can close this one as WONTFIX.