Closed Bug 1543278 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 16289 - Optimise webnfc NFCReader option tests

Categories

(Core :: DOM: Device Interfaces, defect, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16289 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16289
Details from upstream follow.

kaixinjxq <xiuqix.jiang@intel.com> wrote:

Optimise webnfc NFCReader option tests

  • Add the checkpoint of invalid recordType option.
  • Use common function to test url/recordType option.
  • Remove mediaType/url in readOptions.
  • Modify the else if structure in nfc_help.js assertWebNDEFMessagesEqual function.
Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 16289 applied with additional changes from upstream: d4e43ce528d2c1275b655888228f724713e5aef0
Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/61478e53cf66 [wpt PR 16289] - Optimise webnfc NFCReader option tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/61478e53cf66

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.