Remove duplicate gray text variables

RESOLVED FIXED in Firefox 68

Status

enhancement
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: fvsch, Assigned: fvsch)

Tracking

unspecified
Firefox 68

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(4 attachments)

Assignee

Description

2 months ago

As discussed in https://github.com/firefox-devtools/ux/issues/48

Proposed change:

   /* Text color */
   --theme-comment: var(--grey-50);              /* usage: 91 */
-  --theme-comment-alt: var(--grey-40);          /* usage: 23 */
   --theme-body-color: var(--grey-60);           /* usage: 140 */
   --theme-body-color-alt: var(--grey-50);       /* usage: 23 */
   --theme-body-color-inactive: var(--grey-40);  /* usage: 17 */
+  --theme-body-color-strong: var(--grey-80);    /* usage: 17 (content-color1) */
-  --theme-content-color1: var(--grey-80);       /* usage: 17 */
-  --theme-content-color2: var(--grey-60);       /* usage: 6 */
-  --theme-content-color3: var(--grey-45);       /* usage: 10 */
Assignee

Updated

2 months ago
Type: defect → enhancement
Assignee

Updated

2 months ago
Assignee: nobody → florens
Status: NEW → ASSIGNED
Assignee

Comment 6

2 months ago

We have one test and one JS file relying on those variable names.
I update my patches to rename the variables in those files too.

New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfd90a28a8684948b5ac44d9950b5df47a238918

Priority: -- → P3

Comment 7

2 months ago
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/fd95155960a1
Part 1: Replace --theme-content-color1,2,3 variables; r=ntim
https://hg.mozilla.org/integration/autoland/rev/59d2894daa38
Part 2: Rename --theme-body-color-* variables to --theme-text-color-*; r=ntim
https://hg.mozilla.org/integration/autoland/rev/b92e12f815e1
Part 3: Remove --theme-comment-alt variable; r=ntim
https://hg.mozilla.org/integration/autoland/rev/8c2c3afe6a3d
Part 4: Increase body-color contrast (Light) and apply to fonts.css; r=rcaliman
You need to log in before you can comment on or make changes to this bug.