1543324 - Remove duplicate gray text variables

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Florens Verschelde :fvsch]

As discussed in https://github.com/firefox-devtools/ux/issues/48

Proposed change:

   /* Text color */
   --theme-comment: var(--grey-50);              /* usage: 91 */
-  --theme-comment-alt: var(--grey-40);          /* usage: 23 */
   --theme-body-color: var(--grey-60);           /* usage: 140 */
   --theme-body-color-alt: var(--grey-50);       /* usage: 23 */
   --theme-body-color-inactive: var(--grey-40);  /* usage: 17 */
+  --theme-body-color-strong: var(--grey-80);    /* usage: 17 (content-color1) */
-  --theme-content-color1: var(--grey-80);       /* usage: 17 */
-  --theme-content-color2: var(--grey-60);       /* usage: 6 */
-  --theme-content-color3: var(--grey-45);       /* usage: 10 */

Comment 1

[Florens Verschelde :fvsch]

Attachment: Bug 1543324 - Part 1: Replace --theme-content-color1,2,3 variables; r=ntim

Comment 2

[Florens Verschelde :fvsch]

Attachment: Bug 1543324 - Part 2: Rename --theme-body-color-* variables to --theme-text-color-*; r=ntim

Depends on D27106

Comment 3

[Florens Verschelde :fvsch]

Attachment: Bug 1543324 - Part 3: Remove --theme-comment-alt variable; r=ntim

Depends on D27107

Comment 4

[Florens Verschelde :fvsch]

Attachment: Bug 1543324 - Part 4: Increase body-color contrast (Light) and apply to fonts.css; r=rcaliman

Depends on D27108

Comment 5

[Florens Verschelde :fvsch]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb134cac0855f0db5699fd19c5bee7de5648a9d3

Comment 6

[Florens Verschelde :fvsch]

We have one test and one JS file relying on those variable names.
I update my patches to rename the variables in those files too.

New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfd90a28a8684948b5ac44d9950b5df47a238918

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd95155960a1
Part 1: Replace --theme-content-color1,2,3 variables; r=ntim
https://hg.mozilla.org/integration/autoland/rev/59d2894daa38
Part 2: Rename --theme-body-color-* variables to --theme-text-color-*; r=ntim
https://hg.mozilla.org/integration/autoland/rev/b92e12f815e1
Part 3: Remove --theme-comment-alt variable; r=ntim
https://hg.mozilla.org/integration/autoland/rev/8c2c3afe6a3d
Part 4: Increase body-color contrast (Light) and apply to fonts.css; r=rcaliman

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/fd95155960a1
https://hg.mozilla.org/mozilla-central/rev/59d2894daa38
https://hg.mozilla.org/mozilla-central/rev/b92e12f815e1
https://hg.mozilla.org/mozilla-central/rev/8c2c3afe6a3d