1543349 - Use custom tooltip for inactive properties

Status: RESOLVED WORKSFORME

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Tooltips.png

We need to add custom tooltips so that we can show links etc.

Comment 1

[Victoria Wang [:victoria]]

Thanks Mike - when we get closer to compiling the full list of warning types, I may want to refine this design (in case it needs to be larger, more structured looking, etc).

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1306054 - Use custom tooltip for inactive properties r?pbro!,jdescottes!

Depends on D29025

Comment 3

[Francesco Lodolo [:flod]]

Bug 1306054 landed last night with a lot of strings.
https://hg.mozilla.org/mozilla-central/diff/4369c5635972adec6ec3c81a6c7a650aec454b60/devtools/client/locales/en-US/inspector.properties

This bug is changing them all, and that would require new IDs.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

As it stands, this would require ~90 languages to translate everything twice, and that's far from being OK.

We should not land strings to change them all a few days later, and I can't wait on this second patch to land, since we're in the middle of the TrailHead project.

How can we fix this? Can we back out bug 1306054 and land the final version of the strings later?

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Yes, please go ahead.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92c9bfd8d9a6aa12cbc950d3d5e36adca3c02094

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=93e2069876e5f6ebfa9db8437c962ccc28039c1a

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d7fccd0311b3fdaefb0218cdeaa1db3231ef42c

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9205a6d7db98f565c7234d508839511b49245785

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I am blocked on bug 1550021, which appears to be a Fluent bug.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e96ebfc0a2861275277fc49edfb637f0c532f04e

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b97f1912bf129054d17b0f3dcc6af70caf223a7

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de28939206d444dc4b534a3e5cc7a84b8797bec3

Comment 13

[Phabricator Automation]

Comment on attachment 9061671 [details]
Bug 1306054 - Use custom tooltip for inactive properties r?pbro!,jdescottes!

Revision D29372 was moved to bug 1306054. Setting attachment 9061671 [details] to obsolete.

Comment 14

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The patch has been moved to bug 1306054 due to localization issues.