Closed Bug 1543349 Opened 4 months ago Closed 3 months ago

Use custom tooltip for inactive properties

Categories

(DevTools :: Inspector: Rules, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: miker, Assigned: miker)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached image Tooltips.png

We need to add custom tooltips so that we can show links etc.

Blocks: 1540753
Has STR: --- → irrelevant

Thanks Mike - when we get closer to compiling the full list of warning types, I may want to refine this design (in case it needs to be larger, more structured looking, etc).

Bug 1306054 landed last night with a lot of strings.
https://hg.mozilla.org/mozilla-central/diff/4369c5635972adec6ec3c81a6c7a650aec454b60/devtools/client/locales/en-US/inspector.properties

This bug is changing them all, and that would require new IDs.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

As it stands, this would require ~90 languages to translate everything twice, and that's far from being OK.

We should not land strings to change them all a few days later, and I can't wait on this second patch to land, since we're in the middle of the TrailHead project.

How can we fix this? Can we back out bug 1306054 and land the final version of the strings later?

Flags: needinfo?(mratcliffe)

Yes, please go ahead.

Flags: needinfo?(mratcliffe)
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Attachment #9061671 - Attachment description: Bug 1543349 - Use custom tooltip for inactive properties r?rcaliman! → Bug 1543349 - Use custom tooltip for inactive properties r?pbro,jdescottes
Attachment #9061671 - Attachment description: Bug 1543349 - Use custom tooltip for inactive properties r?pbro,jdescottes → Bug 1543349 - Use custom tooltip for inactive properties r?pbro!,jdescottes!

I am blocked on bug 1550021, which appears to be a Fluent bug.

Attachment #9061671 - Attachment description: Bug 1543349 - Use custom tooltip for inactive properties r?pbro!,jdescottes! → Bug 1306054 - Use custom tooltip for inactive properties r?pbro!,jdescottes!

Comment on attachment 9061671 [details]
Bug 1306054 - Use custom tooltip for inactive properties r?pbro!,jdescottes!

Revision D29372 was moved to bug 1306054. Setting attachment 9061671 [details] to obsolete.

Attachment #9061671 - Attachment is obsolete: true

The patch has been moved to bug 1306054 due to localization issues.

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.