Closed Bug 1543420 Opened 7 years ago Closed 7 years ago

Ban SlashIsInvalid followed by SlashIsDiv

Categories

(Core :: JavaScript Engine, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

Currently we allow scanning a token with SlashIsInvalid, then later getting the same token with SlashIsDiv. This is bizarre, and it turns out we can fix it by simplifying the code.

With this change, the use of SlashIsInvalid at the top of
GeneralParser<>::classMember obliges us to use the same modifier when getting
the same token later (in both classMember and propertyName).

Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b410f871d04a Ban SlashIsInvalid followed by SlashIsDiv. r=arai
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → jorendorff
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: