searchfox.org/mozilla-mobile path filtering appears to not work when filter includes submodule name
Categories
(Webtools :: Searchfox, defect)
Tracking
(Not tracked)
People
(Reporter: nalexander, Assigned: kats)
References
Details
To reproduce:
-
Navigate to https://searchfox.org/mozilla-mobile/search?q=version+%3D&case=false®exp=false&path=
-
Remember the first link. For me, it's
android-components/automation/taskcluster/decision_task.py
215 version = components_version() if version is None else version
-
Filter by path prefix from the first link, like https://searchfox.org/mozilla-mobile/search?q=version+%3D&path=android-components%2F
-
Observe no results.
Presumably this is very similar to Bug 1543473 and has to do with the submodule paths as well.
|
Assignee | |
Comment 1•6 years ago
|
||
Yeah in this case the "android-components" bit is actually the submodule path and so it falls through the cracks during the path filtering. I'll look into fixing it. However if you search for any path component beyond that (e.g. "automation/") it seems to filter properly.
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
Fixing https://github.com/livegrep/livegrep/issues/216 and removing the special handling of submodules from searchfox's codesearch integration seems to solve this problem. I have all the pieces, just need to clean it up and get stuff merged.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Upstream livegrep PR was merged.
https://github.com/mozsearch/mozsearch/pull/202 updates our side to use it, which fixes this bug.
|
|
Assignee | |
Comment 4•6 years ago
|
||
This is deployed now
Description
•