Closed Bug 1543525 Opened 6 years ago Closed 6 years ago

Outlines of the empty inlines of an IB split are painted (was: Google mobile has bad looking outline when you select a search result)

Categories

(Core :: Layout, defect)

Unspecified
All
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 434301

People

(Reporter: jrmuizel, Unassigned)

Details

Attachments

(1 file)

Chrome has no dotted selection. Fenix has an ugly not-even rectangular dotted selection.

I can reproduce this on desktop (with mobile UA) so this is not GeckoView specific.

.

Component: General → Layout
Product: GeckoView → Core
Summary: Google has bad looking dotted selection when you select a search result → Google mobile has bad looking outline when you select a search result

Huh, curiously our behavior for outline painting for IB splits depends on quirks mode...

Testcase: data:text/html,<!doctype html><span style="outline: 1px solid;"><div>A</div><div>B</div></span>

But data:text/html,<span style="outline: 1px solid;"><div>A</div><div>B</div></span> renders differently, without the outline of the empty inline.

Summary: Google mobile has bad looking outline when you select a search result → Outlines of the empty inlines of an IB split are painted (was: Google mobile has bad looking outline when you select a search result)

I suspect this is the quirk that causes the different rendering in standards mode and quirks mode: https://searchfox.org/mozilla-central/rev/dd7e27f4a805e4115d0dbee70e1220b23b23c567/layout/generic/nsLineLayout.cpp#1814

I can try to take a look when I have some free time, but if this is prioritary or something please steal.

Flags: needinfo?(emilio)

See also bug 1458477 and bug 434301 (of which both this and bug 1458477 are duplicates, afaict).

I don't think it's that quirk since that's a quirk that influences the influence of an empty-ish box on line height calculation, not one that influences the size of the box.

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #6)

See also bug 1458477 and bug 434301 (of which both this and bug 1458477 are duplicates, afaict).

I agree.

(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #7)

I don't think it's that quirk since that's a quirk that influences the influence of an empty-ish box on line height calculation, not one that influences the size of the box.

Yeah, fair enough. Was just a bit of a guess from grepping NavQuirks on layout/.

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(emilio)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: