1543549 - android wpt-reftest spamming "IndexError: list index out of range" to failure logs, even for passing runs

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If you look at https://treeherder.mozilla.org/logviewer.html#?job_id=237448124&repo=mozilla-central there are a lot of errors logged saying "IndexError: list index out of range" that seem to happen after tests finish.

They happen even for passing wpt-reftest runs like https://treeherder.mozilla.org/logviewer.html#?job_id=237448118&repo=mozilla-central

This only seems to be affecting android test runs, and they appear to have started in the merge to m-c that included bug 1531909: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&tochange=e8b3c73b4e328be88aa90f31e1fa9772b537507d&searchStr=android%2C%28wr&fromchange=5a85cf971fef1404d6ed2893263f609c5a0de2d9&selectedJob=237455770

Android wpt is only enabled on m-c and try, and is tier-2 so it's not surprising this wasn't caught prior to the merge.

I'd guess this is because Android handles windows differently?

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I added some logging around executormarionette.py line 908 to see what handles was, and it's an empty list on android. Linux has a list with at least one window id.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Bug 1543549 - Only switch_to_window() if we have a handle to it. r?jgraham

On android wpt reftests, the window handles list is empty, so we can't use it to switch to a window. Not doing this in that case doesn't seem to break anything, and not doing it in that case prevents the IndexError from being logged to the error log.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df13d5a937b5
Only switch_to_window() if we have a handle to it. r=jgraham

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/df13d5a937b5

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16511 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged