Closed Bug 1543578 Opened 5 years ago Closed 5 years ago

IME isn't available until moving focus from auto focused editor which is new tab created by addon.

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P1)

68 Branch
x86
Windows 10
defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 + verified

People

(Reporter: masayuki, Assigned: hsivonen)

References

(Regression)

Details

(Keywords: inputmethod, regression)

Attachments

(1 file)

[Tracking Requested - why for this release]: Serious regression for IME users.

STR:
0. Log in to twitter.

  1. Install this addon https://addons.mozilla.org/firefox/addon/share-with-sns/
  2. Enable twitter from its option and make sure its button in the toolbar.
  3. Click "Share page with Twitter" in the dropdown of the button.
  4. Then, the contenteditable must have focus in opened tab, try to use IME without focus move.

ER:
IME is available.

AR:
IME is not available.

According to the regression range, looks like a regression of bug 1524975.

Flags: needinfo?(hsivonen)

Oops, it's not contenteditable, just <textarea>.

Looks like that focus is moved by autofocus attribute of the <textarea> element. I guess that there is race issue with closing the dropdown and focus move.

Oh, I found similar bug.

STR:
0. Make menubar visible on Windows.

  1. Set focus to a <textarea> in anywhere.
  2. Click [Edit] -> [Copy]
  3. Open IME and type something.

ER:
IME starts composition in the <textarea>.

AR:
IME starts composition in its floating window.

The result means that IMEStateManager fails to restore input context with focused content in focused content process when menu/popup is closed with some conditions. I cannot reproduce this with the hamburger menu.

Version: Trunk → 68 Branch

IME (Mozc) works for me when following the steps in comment 0 on Ubuntu, so looks like Windows-specific bug.

(In reply to Henri Sivonen (:hsivonen) from comment #4)

IME (Mozc) works for me when following the steps in comment 0 on Ubuntu, so looks like Windows-specific bug.

I can't reproduce comment 0 on Windows 10 1803 using Microsoft IME for Japanese or using Microsoft ChangJie.

Can you still reproduce comment 0?

(I can reproduce comment 3 on Windows 10.)

Flags: needinfo?(masayuki)

Bug 1543363 seems possibly related.

(In reply to Henri Sivonen (:hsivonen) from comment #5)

(In reply to Henri Sivonen (:hsivonen) from comment #4)

IME (Mozc) works for me when following the steps in comment 0 on Ubuntu, so looks like Windows-specific bug.

I can't reproduce comment 0 on Windows 10 1803 using Microsoft IME for Japanese or using Microsoft ChangJie.

Can you still reproduce comment 0?

Oh, I realized that my STR is not enough. If the popup is still open, I can use IME, but if I click the <textarea> to close the popup, I cannot use IME.

(Sorry for the delay to reply.)

Flags: needinfo?(masayuki)
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED

Henri, any updates for this? It's being tracked for 68. Thanks!

Flags: needinfo?(hsivonen)

(In reply to Patricia Lawless from comment #10)

Henri, any updates for this? It's being tracked for 68. Thanks!

The discussion moved to Phabricator. I'm not familiar enough with the requirements/constraints to continue without further advice.

Needinfoing Masayuki here just in case.

Flags: needinfo?(hsivonen) → needinfo?(masayuki)

New regression and simply this makes IME users confused (including dead key users on Linux and macOS) if they use the addon or other addons which have similar UI. So, we need to fix this even in the Beta cycle.

I'm reading current IMEStateManager again...

Flags: needinfo?(masayuki)
Priority: P2 → P1
Attachment #9060060 - Attachment description: Bug 1543578 - Avoid synthetizing TabParent IME focus change when opening a menu. → Bug 1543578 - Avoid synthetizing BrowserParent IME focus change when opening a menu.
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adb37249163e
Avoid synthetizing BrowserParent IME focus change when opening a menu. r=masayuki
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: qe-verify+

Hello! I reproduced the issue with steps from comment 0 / comment 7 and comment 3 using Firefox 68.0a1 (20190410100020) on windows 10x64 (Microsoft IME for Japanese).

The issue is verified using Firefox 69.0a1 (20190627214735) and 68.0b14 (20190627143605) on Windows 10 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: