Some JSOP_DEBUGAFTERYIELD changes

RESOLVED FIXED in Firefox 68

Status

()

task
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

2 months ago

I want to rename it to JSOP_AFTERYIELD (the debugger-only ship has sailed with AbstractGeneratorObject::isAfterYieldOrAwait) and make it a jump target op so that the interpreter will correctly restore its interpreterICEntry field when resuming a generator.

Assignee

Comment 2

2 months ago

This will help the Baseline interpreter restore its interpreterICEntry field
without calling into C++.

Depends on D27032

Priority: -- → P2

Comment 3

2 months ago
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4584d95fcaea
part 1 - Rename JSOP_DEBUGAFTERYIELD to JSOP_AFTERYIELD. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c35e1a0a6cfb
part 2 - Make JSOP_AFTERYIELD a jump target op. r=tcampbell

Comment 4

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.