1543597 - Remove code of blocklist clients in Remote Settings

Status: RESOLVED INVALID

(Toolkit :: Blocklist Implementation, enhancement, P3)

Description

[Mathieu Leplatre [:leplatrem]]

When working on Bug 1257565 we had done the first step which consisted of using Remote Settings to update blocklist information off trains.

However, since Bug 1257565 is not going to happen anytime soon, we should probably remove the code.

• anyone looking at this code would wonder why do we fetch blocklist data from two places (remote settings and XML). The only rational answer is «it's temporary». It's been 2+ years.
• the data of addons and plugins blocklists is synchronized locally but never used (the downloaded XML is the reference)
• the data is modified quite often which triggers push notifications that are not necessary
• the signature is computed often for nothing

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1543597 - Remove code of blocklist clients in Remote Settings

Remove code of blocklist clients in Remote Settings

Comment 2

[Mathieu Leplatre [:leplatrem]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8a5dd1a894d76ebcf6a1a0df013553ba06eee3a

Comment 3

[:Gijs (he/him)]

(In reply to Mathieu Leplatre [:leplatrem] from comment #0)

However, since Bug 1257565 is not going to happen anytime soon, we should probably remove the code.

We could just pref it off by default? I thought there was already a pref... did the pref get removed?

Also, Mike, I think you were the last person to chase this, are we sure we're not going to be pursuing this soon? It's a bit disheartening...

Comment 4

[Mike Conley (:mconley) (:⚙️)]

I'll confer with esmyth and see if he can press this forward.

Comment 5

[Mathieu Leplatre [:leplatrem]]

We could just pref it off by default? I thought there was already a pref... did the pref get removed?

There used to be a pref a very long time ago, and I can't find the commit that removed it.

We could pref it off, but if there's no concrete plan to get out of the blocklist.xml fetch situation then we should probably remove the whole code, no?

Comment 6

[Mathieu Leplatre [:leplatrem]]

Bug 1257565 just happened :tada:!