Prevent content from adding place flavors to a DataTransfer

VERIFIED FIXED in Firefox -esr60

Status

()

defect
P1
normal
VERIFIED FIXED
2 months ago
2 months ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
Firefox 68
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr60 fixed, firefox67 verified, firefox68 verified)

Details

Attachments

(1 attachment)

Assignee

Description

2 months ago

These flavors are not intended to be used by content, so we can prevent them. Though, I must check this won't prevent WebExtensions from adding them.

Comment 2

2 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/b5f523e6d498
Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin

Comment 3

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee

Comment 4

2 months ago

Comment on attachment 9057600 [details]
Bug 1543694 - Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: See bug 1543191
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See bug 1543191
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial patch
  • String changes made/needed: none

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: See bug 1543191
  • User impact if declined: See bug 1543191
  • Fix Landed on Version: 68
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial patch
  • String or UUID changes made by this patch: none
Attachment #9057600 - Flags: approval-mozilla-esr60?
Attachment #9057600 - Flags: approval-mozilla-beta?
Assignee

Updated

2 months ago
Flags: qe-verify?

Comment on attachment 9057600 [details]
Bug 1543694 - Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin

Low risk patch with tests, approved for 67 beta, thanks.

Attachment #9057600 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Would it be possible to get access to bug 1543191 in order to determine if this is something manual QA can cover or not? If access to the bug is not possible then can you please provide some steps in this bug?

Flags: needinfo?(mak77)
Assignee

Comment 8

2 months ago

Yep, added you

Flags: needinfo?(mak77)

Thanks, adding qe-verify+ in this case.

QA Whiteboard: [qa-triaged]
Flags: qe-verify? → qe-verify+

Comment 10

2 months ago

Verified on Nightly 68(20190418221600)and Beta 67(20190418160535), using the attachment from Bug 1543191. The place: url cannot be dropped to Bookmarks Toolbar/Sidebar.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+

Comment on attachment 9057600 [details]
Bug 1543694 - Prevent content from adding place flavors to a DataTransfer. r=NeilDeakin

Fix for bookmarks issue, OK for uplift for ESR 60.7.

Attachment #9057600 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.