1543723 - The import message icon is cut when the screen is horizontally resized to less than half screen

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: image.png

[Affected versions]:

• Firefox Nightly 68.0a1, Build ID 20190409221047
• Firefox Beta 67.b9, Build ID 20190408123043
• Firefox Release 66.0.3, Build ID 20190409155332

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Start the browser with a clean new profile and open a new tab.
2. Resize the browser window to 1/4 size horizontally.
3. Observe the icon to the left of the "Try Firefox with the bookmarks, history and passwords from another browser." message.

[Expected results]:

• The icon is fully visible.

[Actual results]:

• The left and right parts of the icon are cut.

[Regression range]:
6:20.88 INFO: Last good revision: 10fab7177ee397815f7b1e0b2c51437466e62268
6:20.88 INFO: First bad revision: a6a21ea56a9c8f50a7f3dea145050985e7c4c0a5
6:20.88 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=10fab7177ee397815f7b1e0b2c51437466e62268&tochange=a6a21ea56a9c8f50a7f3dea145050985e7c4c0a5

Looks like this was introduced by Bug 1374540.

[Notes]:

• Attached a screenshot of the issue.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Regression in 61, adjusting release tracking flags.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4907

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/mozilla/activity-stream/commit/ea2658d90b3554b02d7224b95a378ef5affd4cd3

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8ff5048f2b90

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

The issue is no longer reproducible on the latest Nightly 68.0a1 (Build ID 20190423221610) on Windows 10 x64, Mac 10.14, and Arch Linux 4.14.3.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Is that something that needs uplifting to beta or can we let it ride the 68 train?

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Pascal Chevrel:pascalc from comment #6)

Is that something that needs uplifting to beta or can we let it ride the 68 train?

It's an edge case, so I don't think it is worth the effort to uplift. And on 68 we ended up removing the message completely afterward this fix.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

thanks, adjusting tracking flags accordingly :)