Closed Bug 1543785 Opened 7 months ago Closed Last month

supportsWasm should be in redux

Categories

(DevTools :: Debugger, task, P3)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: jlast, Assigned: zhaogangse)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 obsolete file)

currently the supportsWasm field is only stored in firefox/commands.js. It would be more consistent if it were stored in reducers/debuggee and set in actions/connect.

Type: defect → task
Priority: -- → P3
Keywords: good-first-bug

One good generalization would be to add all of the target traits to the debuggee reducer. This would make it easy for components to see if a target supports a given capability.

here's a patch with some more context
https://gist.github.com/b763d594202c2ac0a10cad37a62b15de

Now all traits of the tab target are stored inside reducers/threads via the navigate action, and getters of two of them (wasmBinarySource, canRewind) are explicitly exported.

Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10417c711dbf
Store target traits in the reducer for convenience. r=jlast

Backed out changeset 10417c711dbf (Bug 1543785) for source-test-node-debugger-tests fail.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=10417c711dbfdc19642431b148f12d1ec57c15cc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270104133&repo=autoland&lineNumber=729

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=270104483&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b7b6632113c06b38e44cbbfc977c6ca728fcb8b3

task 2019-10-07T17:26:49.370Z] Test Suites: 1 failed, 205 passed, 206 total
[task 2019-10-07T17:26:49.370Z] Tests:       1 failed, 8 skipped, 1746 passed, 1755 total
[task 2019-10-07T17:26:49.370Z] Snapshots:   447 passed, 447 total
[task 2019-10-07T17:26:49.370Z] Time:        61.591s
[task 2019-10-07T17:26:49.370Z] Ran all test suites in 5 projects.
[task 2019-10-07T17:26:49.370Z] error Command failed with exit code 1.
[task 2019-10-07T17:26:49.377Z] TEST-UNEXPECTED-FAIL jest |   ● pause › stepping › maps frame to original frames
[task 2019-10-07T17:26:49.377Z] TEST START | Stylelint
[task 2019-10-07T17:26:51.362Z] yarn run v1.9.4
[task 2019-10-07T17:26:51.362Z] $ stylelint "src/components/**/*.css"
[task 2019-10-07T17:26:51.362Z] Done in 1.60s.
[task 2019-10-07T17:26:51.362Z] 
[task 2019-10-07T17:26:51.362Z] TEST START | Eslint (JSX Accessibility)
[task 2019-10-07T17:27:40.073Z] yarn run v1.9.4
[task 2019-10-07T17:27:40.073Z] $ eslint *.js "src/**/*.js" "packages/*/src/**/*.js" --plugin=jsx-a11y --config=.eslintrc.jsx-a11y
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/utils/middleware/promise.js
[task 2019-10-07T17:27:40.073Z]   42:12  warning  Call to pending()  jest/no-disabled-tests
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/A11yIntention.js
[task 2019-10-07T17:27:40.073Z]   31:7  warning  Static HTML elements with event handlers require a role  jsx-a11y/no-static-element-interactions
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/ConditionalPanel.js
[task 2019-10-07T17:27:40.073Z]   211:7  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
[task 2019-10-07T17:27:40.073Z]   211:7  warning  Static HTML elements with event handlers require a role                                         jsx-a11y/no-static-element-interactions
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreview.js
[task 2019-10-07T17:27:40.073Z]   47:7  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
[task 2019-10-07T17:27:40.073Z]   47:7  warning  Static HTML elements with event handlers require a role                                         jsx-a11y/no-static-element-interactions
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/Preview/Popup.js
[task 2019-10-07T17:27:40.073Z]   105:7  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
[task 2019-10-07T17:27:40.073Z]   105:7  warning  Static HTML elements with event handlers require a role                                         jsx-a11y/no-static-element-interactions
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/Tab.js
[task 2019-10-07T17:27:40.073Z]   210:7  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
[task 2019-10-07T17:27:40.073Z]   210:7  warning  Static HTML elements with event handlers require a role                                         jsx-a11y/no-static-element-interactions
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/Tabs.js
[task 2019-10-07T17:27:40.073Z]   146:7  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
[task 2019-10-07T17:27:40.073Z]   146:7  warning  Non-interactive elements should not be assigned mouse or keyboard event listeners               jsx-a11y/no-noninteractive-element-interactions
[task 2019-10-07T17:27:40.073Z] 
[task 2019-10-07T17:27:40.073Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/PrimaryPanes/Outline.js
[task 2019-10-07T17:27:40.073Z]   201:7  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
[task 2019-10-07T17:27:40.073Z]   201:7  warning  Non-interactive elements should not be assigned mouse or keyboard event listeners               jsx-a11y/no-noninteractive-element-interactions
[task 2019-10-07T17:27:40.073Z]   249:9  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
[task 2019-10-07T17:27:40.073Z]   249:9  warning  Non-interactive elements should not be assigned mouse or keyboard event listeners               jsx-a11y/no-noninteractive-element-interactions
Flags: needinfo?(jlaster)
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ddd33182005
Store target traits in the reducer for convenience.
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Assignee: nobody → zhaogangse
Attachment #9099112 - Attachment is obsolete: true
Flags: needinfo?(jlaster)
You need to log in before you can comment on or make changes to this bug.