1543817 - Clean up Normandy data

Status: RESOLVED FIXED

(Firefox :: Normandy Client, enhancement)

Description

[Ethan Glasser-Camp (:glasserc)]

• Normandy actions report cumulative statuses at the end of every run. However, AddonStudyAction reports its status twice due to a quirk of code organization. This confuses the data for no reason.

• In bug 1530508, I needed to choose a status for "recipe did not match", and I chose UptakeTelemetry.STATUS.CUSTOM_2_ERROR. This has led to a number of panicky questions when someone sees this for the first time. Since it's not actually an error, we should choose a safer-sounding status such as BACKOFF.

Comment 1

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1543817: Use BACKOFF for "recipe didn't match"

Comment 2

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1543817: Don't finalize any action twice

Depends on D27362

Comment 3

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dc215c01707224de6493f6a97ccdfb0a2d094b4

Comment 4

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1543817: Document different Normandy uptake telemetry values

Depends on D27363

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c62bdc7e166
Use BACKOFF for "recipe didn't match" r=mythmon
https://hg.mozilla.org/integration/autoland/rev/2f68e9e0c239
Don't finalize any action twice r=mythmon
https://hg.mozilla.org/integration/autoland/rev/be3f40425b52
Document different Normandy uptake telemetry values r=mythmon

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3c62bdc7e166
https://hg.mozilla.org/mozilla-central/rev/2f68e9e0c239
https://hg.mozilla.org/mozilla-central/rev/be3f40425b52