Port bug 1506913: Find bar not readable with certain themes

RESOLVED FIXED in Thunderbird 68.0

Status

task
RESOLVED FIXED
a month ago
29 days ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 68.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

a month ago

M-C changed some code for the findbar. We can follow.

Assignee

Comment 1

a month ago

Straight port of https://hg.mozilla.org/mozilla-central/rev/53c0f17ba52c

LW-themes don't work on trunk. So I can't really test it. Only checked with the built-in themes.

What I see also without the patch is, that in main window when I open the findbar, the textbox has a "undefined" in it. Maybe something for a new bug.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9057678 - Flags: review?(jorgk)

Comment 2

a month ago

(In reply to Richard Marti (:Paenglab) from comment #1)

LW-themes don't work on trunk. So I can't really test it. Only checked with the built-in themes.

So what is the story with LW themes? Weren't they discontinued and moved to WE themes? Can't we create a WE theme with a "header image"?

What I see also without the patch is, that in main window when I open the findbar,
the textbox has a "undefined" in it. Maybe something for a new bug.

Yes, certainly something for a new bug. Can you please file one.

Assignee

Comment 3

a month ago

LW-themes are now WE-themes. The most have only a background image and a text colour set. With TB 68 we can use the LW-(now WE)-themes from FX.

Comment 4

a month ago

OK, and such a theme can't be used for testing?

Assignee

Comment 5

a month ago

Yes. With https://addons.mozilla.org/en-US/firefox/addon/galaxy-blue/ you see the issue. Without patch, the text in the find bar is white, with patch black.

Comment 6

a month ago
Comment on attachment 9057678 [details] [diff] [review]
1543820-findbar-colors.patch

OK, I checked the ported hunks, and you did additional testing, so ready to go.
Attachment #9057678 - Flags: review?(jorgk) → review+
Assignee

Updated

a month ago
Keywords: checkin-needed

Comment 7

a month ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e614af523881
Port bug 1506913: Don't apply theme colors on findbar when theme has a header image. r=jorgk

Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

a month ago
Target Milestone: --- → Thunderbird 68.0

Updated

29 days ago
Type: defect → task
You need to log in before you can comment on or make changes to this bug.