Port bug 1506913: Find bar not readable with certain themes
Categories
(Thunderbird :: Theme, task)
Tracking
(Not tracked)
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
3.04 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
M-C changed some code for the findbar. We can follow.
Assignee | ||
Comment 1•5 years ago
|
||
Straight port of https://hg.mozilla.org/mozilla-central/rev/53c0f17ba52c
LW-themes don't work on trunk. So I can't really test it. Only checked with the built-in themes.
What I see also without the patch is, that in main window when I open the findbar, the textbox has a "undefined" in it. Maybe something for a new bug.
Comment 2•5 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #1)
LW-themes don't work on trunk. So I can't really test it. Only checked with the built-in themes.
So what is the story with LW themes? Weren't they discontinued and moved to WE themes? Can't we create a WE theme with a "header image"?
What I see also without the patch is, that in main window when I open the findbar,
the textbox has a "undefined" in it. Maybe something for a new bug.
Yes, certainly something for a new bug. Can you please file one.
Assignee | ||
Comment 3•5 years ago
|
||
LW-themes are now WE-themes. The most have only a background image and a text colour set. With TB 68 we can use the LW-(now WE)-themes from FX.
Comment 4•5 years ago
|
||
OK, and such a theme can't be used for testing?
Assignee | ||
Comment 5•5 years ago
|
||
Yes. With https://addons.mozilla.org/en-US/firefox/addon/galaxy-blue/ you see the issue. Without patch, the text in the find bar is white, with patch black.
Comment 6•5 years ago
|
||
Comment on attachment 9057678 [details] [diff] [review] 1543820-findbar-colors.patch OK, I checked the ported hunks, and you did additional testing, so ready to go.
Assignee | ||
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e614af523881
Port bug 1506913: Don't apply theme colors on findbar when theme has a header image. r=jorgk
Updated•5 years ago
|
Updated•5 years ago
|
Description
•