Closed Bug 1543843 Opened 2 years ago Closed 2 years ago

Add constructor to JSPropertySpec and/or inner structs/unions

Categories

(Core :: JavaScript Engine, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

bug 1543659 is caused by initializing JSPropertySpec fields by using different (the first) field.

The issue can be fixed by using constexpr constructors there.

I'm going to experiment

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

Comment on attachment 9057861 [details]
Bug 1543843 - Add constructors to JSPropertySpec and inner structs/unions. r?jwalden

Using this instead of my patch in bug 1543659 also fixes the TypedArrays tests on s390x.

Attachment #9057861 - Flags: feedback+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/bc11fcee5741
Add constructors to JSPropertySpec and inner structs/unions. r=jwalden
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1549340
You need to log in before you can comment on or make changes to this bug.